Skip to content

Fixed relative paths for Flang out-of-tree builder. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

vzakhari
Copy link
Contributor

After llvm/llvm-project#87822
we can specify real relative paths from the flang build directory
to the directories containing LLVM/CLANG/etc. projects' config
files.

After llvm/llvm-project#87822
we can specify real relative paths from the flang build directory
to the directories containing LLVM/CLANG/etc. projects' config
files.
@vzakhari vzakhari requested review from ceseo, rovka and luporl April 10, 2024 19:22
Copy link

@ceseo ceseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vzakhari
Copy link
Contributor Author

I do not know how to test this locally, so I am going to merge this and see what happens with the buildbots.

@ceseo
Copy link

ceseo commented Apr 10, 2024

OK, but it looks correct to me now.

@luporl probably knows how to test this locally.

@vzakhari vzakhari merged commit a3a80fe into llvm:main Apr 10, 2024
@luporl
Copy link
Contributor

luporl commented Apr 10, 2024

@luporl probably knows how to test this locally.

It can be done, but it takes some work.
Basically, you need to setup a local build master and add a build worker to it, that matches with the builder that you want to test. I don't know if there is an easier way to test it.

But let's hope this fixes the buildbot, which is broken anyway.

@vzakhari
Copy link
Contributor Author

I forced the build, but it looks like the buildbot did not pick up these changes immediately. I will keep an eye on it.

@luporl
Copy link
Contributor

luporl commented Apr 10, 2024

The change will be picked up next time the build master is reconfigured, which can take some time.

@vzakhari
Copy link
Contributor Author

Hi @omjavaid, sorry to bother you. By any chance do you know when https://lab.llvm.org/buildbot/#/builders/175 builder will pick up my changes from this PR?

@luporl
Copy link
Contributor

luporl commented Apr 15, 2024

Hi @omjavaid, sorry to bother you. By any chance do you know when https://lab.llvm.org/buildbot/#/builders/175 builder will pick up my changes from this PR?

https://lab.llvm.org/buildbot/#/builders/175 should pick your changes as soon as the build master is reconfigured.
@gkistanova might know when that will happen.

@vzakhari
Copy link
Contributor Author

Hi @luporl, can you please give me any pointers how to do setup a local build master and add a build worker to it, that matches with the builder that you want to test? I reverted my llvm-project changes, and I want to try my builder changes locally. It looks like this PR did not fix the issue, and the buildbot continued failing for a long time.

@antmox
Copy link
Contributor

antmox commented Apr 19, 2024

Hi @vzakhari , could this be the cause of current flang-aarch64-out-of-tree bot failure ? https://lab.llvm.org/buildbot/#/builders/175/builds/46750

@luporl
Copy link
Contributor

luporl commented Apr 19, 2024

It looks like we're out of luck, because it seems this patch was finally picked up by the build master, just when llvm/llvm-project#87822 was reverted.
@vzakhari, maybe if you reland llvm/llvm-project#87822 now it will work.

@luporl
Copy link
Contributor

luporl commented Apr 19, 2024

Hi @luporl, can you please give me any pointers how to do setup a local build master and add a build worker to it, that matches with the builder that you want to test? I reverted my llvm-project changes, and I want to try my builder changes locally. It looks like this PR did not fix the issue, and the buildbot continued failing for a long time.

I've used some internal documents to setup a local build master and worker. I'm checking if it's possible to make it available. For setting a build worker, there is https://llvm.org/docs/HowToAddABuilder.html.

To create a master: https://docs.buildbot.net/current/tutorial/firstrun.html#creating-a-master

@vzakhari
Copy link
Contributor Author

Thanks for the heads up! Yes, it looks like the change finally kicked in! I was told that the update happens every Friday, so it looks like it just did not happen the last Friday. I will reapply my llvm-project change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants