-
Notifications
You must be signed in to change notification settings - Fork 112
Fixed relative paths for Flang out-of-tree builder. #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After llvm/llvm-project#87822 we can specify real relative paths from the flang build directory to the directories containing LLVM/CLANG/etc. projects' config files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I do not know how to test this locally, so I am going to merge this and see what happens with the buildbots. |
OK, but it looks correct to me now. @luporl probably knows how to test this locally. |
It can be done, but it takes some work. But let's hope this fixes the buildbot, which is broken anyway. |
I forced the build, but it looks like the buildbot did not pick up these changes immediately. I will keep an eye on it. |
The change will be picked up next time the build master is reconfigured, which can take some time. |
Hi @omjavaid, sorry to bother you. By any chance do you know when https://lab.llvm.org/buildbot/#/builders/175 builder will pick up my changes from this PR? |
https://lab.llvm.org/buildbot/#/builders/175 should pick your changes as soon as the build master is reconfigured. |
Hi @luporl, can you please give me any pointers how to do |
Hi @vzakhari , could this be the cause of current flang-aarch64-out-of-tree bot failure ? https://lab.llvm.org/buildbot/#/builders/175/builds/46750 |
It looks like we're out of luck, because it seems this patch was finally picked up by the build master, just when llvm/llvm-project#87822 was reverted. |
I've used some internal documents to setup a local build master and worker. I'm checking if it's possible to make it available. For setting a build worker, there is https://llvm.org/docs/HowToAddABuilder.html. To create a master: https://docs.buildbot.net/current/tutorial/firstrun.html#creating-a-master |
Thanks for the heads up! Yes, it looks like the change finally kicked in! I was told that the update happens every Friday, so it looks like it just did not happen the last Friday. I will reapply my llvm-project change. |
After llvm/llvm-project#87822
we can specify real relative paths from the flang build directory
to the directories containing LLVM/CLANG/etc. projects' config
files.