[tools] Fix not utility to work on iOS #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issue #77137. The implementation uses posix_spawn on iOS but std::system elsewhere.
tarunprabhu
requested review from
jroelofs,
tblah,
kiranchandramohan,
cabreraam and
yiwu0b11
tblah
reviewed
Jan 9, 2024
|
As posix_spawn is part of POSIX, it is probably reasonably well available on other platforms (although I don't know about Windows). Perhaps we could get away without the #ifdef here. I don't feel strongly about this. |
yiwu0b11
reviewed
Jan 9, 2024
…er comments from the code review.
yiwu0b11
approved these changes
Jan 9, 2024
jroelofs
approved these changes
Jan 10, 2024
tools/not.cpp
Outdated
| int main(int argc, const char **argv) { | ||
| #ifdef __APPLE__ | ||
| #include <spawn.h> | ||
| #include <wait.h> |
There was a problem hiding this comment.
Suggested change
| #include <wait.h> | |
| #include <sys/wait.h> |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #77137 (std::system is not available on iOS). The implementation uses posix_spawn on iOS but std::system elsewhere.
This has only been tested on Linux on X86 and an older AArch64.
@jroelofs, could you try this on an iOS and let me know if it works there?