Skip to content

[Fortran/gfortran] Enable previously disabled tests #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
465 changes: 0 additions & 465 deletions Fortran/gfortran/regression/DisabledFiles.cmake

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions Fortran/gfortran/regression/analyzer/DisabledFiles.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ set(UNSUPPORTED_FILES "")
file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS
# unimplemented: allocatable components in derived type assignment
pr93777.f90

# unimplemented: gather rhs LEN parameters in assignment to allocatable
deferred_character_25.f90
)

# There are currently no skipped files.
Expand Down
9 changes: 2 additions & 7 deletions Fortran/gfortran/regression/asan/DisabledFiles.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,8 @@
# There are currently no unsupported files.
set(UNSUPPORTED_FILES "")

# These tests are disabled because they trigger a "not yet implemented"
# assertion.
file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS
# unimplemented: character array expression temp with dynamic length
associate_58.f90
associate_59.f90
)
# There are currently no tests that fail because of unimplemented features.
set(UNIMPLEMENTED_FILES "")

# These tests trigger internal compiler errors.
file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
Expand Down
12 changes: 0 additions & 12 deletions Fortran/gfortran/regression/c-interop/DisabledFiles.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,6 @@ file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS
ff-descriptor-5.f90
ff-descriptor-6.f90
ff-descriptor-7.f90
pr103390-1.f90
pr103390-2.f90
pr103390-3.f90
pr103390-4.f90
pr103390-5.f90
pr103390-6.f90
pr103390-7.f90
pr103390-8.f90
pr103390-9.f90

# unimplemented: support for polymorphic types
c407a-1.f90
Expand Down Expand Up @@ -95,10 +86,7 @@ file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
fc-out-descriptor-3.f90
fc-out-descriptor-4.f90
fc-out-descriptor-7.f90
ff-descriptor-1.f90
ff-descriptor-2.f90
ff-descriptor-3.f90
ff-descriptor-4.f90
optional.f90
rank-class.f90
section-2.f90
Expand Down
1 change: 0 additions & 1 deletion Fortran/gfortran/regression/coarray/DisabledFiles.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
collectives_3.f90
get_to_indexed_array_1.f90
lib_realloc_1.f90
pr93671.f90
ptr_comp_3.f08
scalar_alloc_2.f90

Expand Down
53 changes: 1 addition & 52 deletions Fortran/gfortran/regression/goacc/DisabledFiles.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ set(UNSUPPORTED_FILES "")
# There are currently no unimplemented files.
file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS
# unimplemented: CriticalConstruct implementation
critical.f95

# unimplemented: OpenACC Atomic construct not lowered yet
atomic-1.f90
Expand All @@ -21,50 +20,24 @@ file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS

# unimplemented: OpenACC Cache construct not lowered yet
cache-1.f95
cache-2.f95

# unimplemented: OpenACC Routine construct not lowered yet
classify-routine.f95
classify-routine-nohost.f95
kernels-decompose-2.f95
orphan-reductions-1.f90
orphan-reductions-2.f90
pr89773.f90
private-explicit-routine-1.f95
private-predetermined-routine-1.f95
privatization-1-routine_gang.f90
privatization-1-routine_gang-loop.f90
routine-4.f90
routine-5.f90
routine-8.f90
routine-external-level-of-parallelism-1.f
routine-external-level-of-parallelism-2.f
routine-level-of-parallelism-1.f90
routine-module-mod-1.f90
routine-multiple-directives-1.f90
routine-multiple-directives-2.f90

# unimplemented: OpenACC Standalone Declarative construct not lowered yet
declare-1.f95
declare-3.f95
derived-types.f90
pr78260-2.f90
pr85701.f90
pr94120-1.f90
pr94120-2.f90
pr94120-3.f90

# unimplemented: co-array address
coindexed-1.f90

# unimplemented: coarray in procedure interface
coarray_2.f90

# unimplemented: intrinsic: kind requested type: (i32) -> i32
ref_inquiry.f90

# unimplemented: reduction with unsupported type
pr77371-2.f90

# unimplemented: support for polymorphic types
derived-chartypes-1.f90
Expand All @@ -78,23 +51,15 @@ file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS
# These tests are disabled because they cause flang to crash.
file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
# error: unsupported OpenACC operation:
acc.bounds array-with-dt-1a.f90
array-with-dt-1a.f90
array-with-dt-1.f90
array-with-dt-2.f90
array-with-dt-3.f90
array-with-dt-4.f90
array-with-dt-6.f90
attach-descriptor.f90
derived-types-3.f90
kernels-alias-4.f95
kernels-alias.f95

# error: unsupported OpenACC operation: acc.deviceptr
data-clauses.f95

# error: unsupported OpenACC operation: acc.firstprivate
firstprivate-1.f95

# error: unsupported OpenACC operation: acc.firstprivate.recipe
default_none.f95

Expand All @@ -114,13 +79,9 @@ file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
fixed-3.f
fixed-4.f
pr85879.f90
tile-4.f90
uninit-dim-clause.f95
uninit-firstprivate-clause.f95

# error: unsupported OpenACC operation: acc.present
warn_truncated.f90

# error: unsupported OpenACC operation: acc.private.recipe
private-explicit-kernels-1.f95
private-explicit-parallel-1.f95
Expand All @@ -129,19 +90,16 @@ file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
parallel-tree.f95

# error: unsupported OpenACC operation: acc.reduction.recipe
array-reduction.f90
combined-directives.f90
combined_loop.f90
loop-tree-1.f90
modules.f95
multi-clause.f90
orphan-reductions-3.f90
pr85703.f90
private-3.f95
reduction-2.f95

# error: unsupported OpenACC operation: acc.reduction
reduction-3.f95
reduction-promotions.f90

# error: unsupported OpenACC operation: acc.use_device
Expand All @@ -158,7 +116,6 @@ file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
classify-kernels-unparallelized-parloops.f95
classify-parallel.f95
classify-serial.f95
deep-copy-2.f90
gang-static.f95
kernels-decompose-1.f95
kernels-loop-2.f95
Expand All @@ -173,16 +130,11 @@ file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
kernels-loops-adjacent.f95
kernels-parallel-loop-data-enter-exit.f95
loop-2-kernels-nested.f95
loop-2-parallel-3.f95
loop-2-parallel-nested.f95
loop-4.f95
nested-parallelism.f90
note-parallelism.f90
pr104717.f90
pr72715.f90
pr78027.f90
pr84217.f90
pr93329.f90
pr93464-2.f90
pr93464.f90
private-predetermined-kernels-1.f95
Expand All @@ -198,10 +150,7 @@ file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
# error: null operand found
array-with-dt-5.f90
finalize-1.f
mapping-tests-1.f90
mapping-tests-2.f90
mapping-tests-3.f90
mapping-tests-4.f90
update-if_present-1.f90

# error: operation with block successors must terminate its parent block
Expand Down
64 changes: 0 additions & 64 deletions Fortran/gfortran/regression/gomp/DisabledFiles.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,31 +12,21 @@ set(UNSUPPORTED_FILES "")
file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS
# unimplemented: procedure pointers
atomic-10.f90
declare-variant-19.f90
proc_ptr_1.f90
proc_ptr_2.f90

# unimplemented: procedure pointer arguments
pr44036-1.f90
pr44036-2.f90

# unimplemented: coarray in procedure interface
declare-simd-coarray-lib.f90

# unimplemented: gather rhs LEN parameters in assignment to allocatable
atomic-28.f90
defaultmap-2.f90
defaultmap-3.f90
defaultmap-4.f90
defaultmap-5.f90
defaultmap-6.f90

# unimplemented: support for polymorphic types
associate2.f90
class-firstprivate-1.f90
class-firstprivate-2.f90
class-firstprivate-3.f90
class-firstprivate-4.f90
omp_parallel_1.f90
pr102621.f90
pr52531.f90
Expand All @@ -45,84 +35,49 @@ file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS

# unimplemented: derived type components with non default lower bounds
depend-iterator-1.f90
depend-iterator-2.f90

# unimplemented: assumed rank in procedure interface
pr94672.f90
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this started working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is expected to raise a compile-time error with the message

'array' not specified in enclosing 'parallel'

In flang, this now errors with the message:

The DEFAULT(NONE) clause requires that 'array' must be listed in a data-sharing attribute clause

Are these not equivalent?

It was probably hitting a TODO earlier with the assumed rank error message.


# unimplemented: Construct enclosing do loop
allocate-3.f90
combined-if.f90
order-4.f90
openmp-simd-5.f90
openmp-simd-6.f90
pr107214-7.f90
pr79154-2.f90
pr82568.f90
pr87752.f90
pr99226.f90
schedule-modifiers-1.f90
target3.f90
teams1.f90

# unimplemented: array sections not supported for task depend
depend-4.f90

# unimplemented: Missing symbol, possible case of currently unsupported use of
# a program local variable in declare target or erroneous symbol information
implicit-save.f90

# unimplemented: OMPD_target_data for Array Expressions or Structure
# Components.
map-2.f90
map-5.f90
map-9.f90
ref_inquiry.f90
substring.f90

# unimplemented: OMPD_target_update
pr71705.f90

# unimplemented: Do Concurrent in Worksharing loop construct
omp_do_concurrent.f90

# unimplemented: OpenMP Block construct clause
pr107214-5.f90
pr71758.f90
pr77352.f90
pr81887.f90
target-device-2.f90

# unimplemented: OMPD_target_data MapOperand BoxType
pr107214.f90
target-exit-data.f90

# unimplemented: Unhandled block directive
pr39152.f90
pr69128.f90
pr69281.f90
pr70855.f90
pr95869.f90
target-parallel1.f90
teams-4.f90
workshare2.f90
workshare3.f90

# unimplemented: Array references as atomic update variable
pr62131.f90

# unimplemented: OpenMPDeclareSimdConstruct
pr79154-1.f90
pr93555.f90
declare-simd-6.f90

# unimplemented: OpenMPRequiresConstruct
requires-1.f90
requires-5.f90
requires-7.f90
requires-8.f90
requires-9.f90
target-device-ancestor-3.f90
target-device-ancestor-5.f90
target-device-ancestor-6.f90

Expand All @@ -135,7 +90,6 @@ file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS

file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
# error: not a memory reference type
associate1.f90

# error: the update operation inside the region must be a binary operation and
# that update operation must have the region argument as an operand
Expand All @@ -144,24 +98,6 @@ file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
# error: address must dereference to value type
omp_atomic2.f90

# error: symbol must have a type
pr35786-1.f90

# error: expr was not lowered to MutableBoxValue
pr36726.f90
pr77666.f90

# error: exactly two operations are allowed inside an atomic update region
# while lowering to LLVM IR
pr39354.f90

# error: unhandled clauses for translation to LLVM IR
pr43337.f90
pr44085.f90

# error: operand #0 does not dominate this use
pr89651.f90

# error: /usr/lib/gcc/x86_64-pc-linux-gnu/13/include/g++-v13/optional:484:
# const _Tp &std::_Optional_base_impl<Fortran::parser::OmpMapType, std::_Optional_base<Fortran::parser::OmpMapType, false, false>>::_M_get() const [_Tp = Fortran::parser::OmpMapType, _Dp = std::_Optional_base<Fortran::parser::OmpMapType, false, false>]: Assertion 'this->_M_is_engaged()' failed.
nesting-1.f90
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,13 @@ file(GLOB UNIMPLEMENTED_FILES CONFIGURE_DEPENDS
a.11.5.f90
a.11.6.f90
a.11.7.f90

# unimplemented: Common Block in privatization clause
a.23.1.f90
a.23.3.f90
)

file(GLOB SKIPPED_FILES CONFIGURE_DEPENDS
#
# These tests fail when they should pass.
#

# error: 't' appears in more than one data-sharing clause on the same OpenMP
# directive
a.22.6.f90

# error: COMMON block must be declared in the same scoping unit in which the
# OpenMP directive or clause appears
a.23.2.f90
Expand Down
Loading