Port tools/timeit to windows (AArch64, x64) #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstorsjo
reviewed
Nov 29, 2023
This patch implements timeit timing tool found at tools/timeit.c for Windows. It is required for compile time and run time calculations by the llvm-testsuite. At this moment llvm testsuite tests can not be compiled with clang-cl MSVC combination however we have also made required modifications to the cmake files to enable building timeit on windows with clang-cl/cl. In developer console with MSVC following command can be used to successfully build this code: set CC=c:\work\llvm-dev\build\bin\clang-cl.exe set CXX=c:\work\llvm-dev\build\bin\clang-cl.exe cmake -G Ninja -DTEST_SUITE_SUBDIRS= ..\llvm-test-suite Phabricator Review: https://reviews.llvm.org/D153263
mstorsjo
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements timeit timing tool found at tools/timeit.c for Windows.
It is required for compile time and run time calculations by the llvm-testsuite.
At this moment llvm testsuite tests can not be compiled with clang-cl MSVC combination
however we have also made required modifications to the cmake files to enable building
timeit on windows with clang-cl/cl.
In developer console with MSVC following command can be used to successfully build this code:
set CC=c:\work\llvm-dev\build\bin\clang-cl.exe
set CXX=c:\work\llvm-dev\build\bin\clang-cl.exe
cmake -G Ninja -DTEST_SUITE_SUBDIRS= ..\llvm-test-suite
Phabricator Review: https://reviews.llvm.org/D153263