-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libc] New HeaderGen Switch Flip #99929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Flipped option from OFF to ON for automatically building libc with New HeaderGen.
@llvm/pr-subscribers-libc Author: None (RoseZhang03) ChangesFlipped option from OFF to ON for automatically building libc with New Full diff: https://github.com/llvm/llvm-project/pull/99929.diff 1 Files Affected:
diff --git a/libc/CMakeLists.txt b/libc/CMakeLists.txt
index 6e0760724d963..45cca17562d26 100644
--- a/libc/CMakeLists.txt
+++ b/libc/CMakeLists.txt
@@ -73,7 +73,7 @@ if(LIBC_BUILD_GPU_LOADER OR (LLVM_LIBC_GPU_BUILD AND NOT LLVM_RUNTIMES_BUILD))
add_subdirectory(utils/gpu)
endif()
-option(LIBC_USE_NEW_HEADER_GEN "Generate header files using new headergen instead of the old one" OFF)
+option(LIBC_USE_NEW_HEADER_GEN "Generate header files using new headergen instead of the old one" ON)
set(NEED_LIBC_HDRGEN FALSE)
if(NOT LLVM_RUNTIMES_BUILD)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Should this wait until after the LLVM 20 branch on Tuesday? |
I was planning on this landing today (or tomorrow) specifically to make it into the LLVM 19 branch. It should be a fairly safe transition, especially since there will still be the option to use the old headergen. |
I guess if anything breaks we can always backport it. I guess the timeline is land this in 19 and delete tablegen in 20? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go, we can revert if we run into issues.
sounds like a plan to me |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/2164 Here is the relevant piece of the build log for the reference:
|
This reverts commit 93eb9ec.
Flipped option from OFF to ON for automatically building libc with New HeaderGen.
Flipped option from OFF to ON for automatically building libc with New
HeaderGen.