[SandboxIR][NFC] Move sandboxir::Use into a separate file #99074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschuett
reviewed
Jul 16, 2024
llvm/include/llvm/SandboxIR/Use.h
Outdated
| #include "llvm/Support/raw_ostream.h" | ||
|
|
||
| namespace llvm { | ||
| namespace sandboxir { |
There was a problem hiding this comment.
Maybe not. llvm::Use could be forward declared. IIRC raw_ostream can also be forward declared.
There was a problem hiding this comment.
Why would we forward declare llvm::Use?
There was a problem hiding this comment.
Including llvm IR header files is not going to cause any dependency issues, so I think it should be fine to keep it this way.
tschuett
reviewed
Jul 16, 2024
| void dump(raw_ostream &OS) const; | ||
| void dump() const; | ||
| #endif // NDEBUG | ||
| }; |
tschuett
reviewed
Jul 16, 2024
llvm/include/llvm/SandboxIR/Use.h
Outdated
| @@ -0,0 +1,51 @@ | |||
| #ifndef LLVM_TRANSFORMS_SANDBOXIR_USE_H | |||
| #define LLVM_TRANSFORMS_SANDBOXIR_USE_H | |||
There was a problem hiding this comment.
This is not in the transforms directory. Maybe there was a version in transforms. The include guard looks odd.
There was a problem hiding this comment.
It's also missing the LLVM header!
There was a problem hiding this comment.
The TRANSFORMS was copy-pasted from SandboxIR.h.
aeubanks
approved these changes
Jul 16, 2024
This helps avoid circular dependencies in a follow-up patch.
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: This helps avoid circular dependencies in a follow-up patch. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps avoid circular dependencies in a follow-up patch.