Skip to content

[bazel] Fix llvm:Core build #99054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2024
Merged

[bazel] Fix llvm:Core build #99054

merged 1 commit into from
Jul 16, 2024

Conversation

@wecing
Copy link
Contributor

@wecing wecing commented Jul 16, 2024

According to @akuegel, this breakage was introduced in c05126b.

@wecing
[bazel] Fix llvm:Core build
4e74d89 
According to @akuegel, this breakage was introduced in c05126b.
@wecing wecing requested review from keith and rupprecht as code owners July 16, 2024 15:50
@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Jul 16, 2024
@wecing wecing requested review from cjdb and krasimirgg July 16, 2024 15:53
akuegel
akuegel approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@akuegel akuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@wecing wecing merged commit 5b54f36 into llvm:main Jul 16, 2024
chapuni added a commit that referenced this pull request Jul 20, 2024
@chapuni
Revert "[bazel] Fix llvm:Core build (#99054)"
168ecd7 
This reverts commit 5b54f36.
(llvmorg-19-init-17774-g5b54f36fb607)
See #99610
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@wecing @yuxuanchen1997
[bazel] Fix llvm:Core build (#99054)
7dc335e 
Summary: According to @akuegel, this breakage was introduced in c05126b.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251668
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@chapuni @yuxuanchen1997
Revert "[bazel] Fix llvm:Core build (#99054)"
ad9ccaf 
This reverts commit 5b54f36.
(llvmorg-19-init-17774-g5b54f36fb607)
See #99610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akuegel akuegel akuegel approved these changes

@rupprecht rupprecht Awaiting requested review from rupprecht rupprecht is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@cjdb cjdb Awaiting requested review from cjdb

@krasimirgg krasimirgg Awaiting requested review from krasimirgg

Assignees

No one assigned

Labels

bazel "Peripheral" support tier build system: utils/bazel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wecing @akuegel @llvmbot