Skip to content

[libc][math][c23] Add f16fmaf C23 math function #95483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 14, 2024
Merged

[libc][math][c23] Add f16fmaf C23 math function #95483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0f9a842
[libc][math][c23] Add f16fmaf C23 math function
overmighty Jun 13, 2024
06e598e
[libc] Undo disabling of scheduler_test
overmighty Jun 13, 2024
05bc63c
[libc] Fix includes and dependencies
overmighty Jun 13, 2024
b112ac4
[libc] Add blank line between template declaration and specialization
overmighty Jun 13, 2024
7e7c354
[libc][math] Remove useless header guard around fputil::generic::fma<…
overmighty Jun 14, 2024
e409c82
[libc] Misc cleanup
overmighty Jun 14, 2024
bd971fe
[libc] Replace 128-bit BigInt numeric_limits with generic BigInt spec…
overmighty Jun 14, 2024
5dae03b
[libc][math] Fix sign of FMA with exact cancellation
overmighty Jun 14, 2024
9d4dc22
[libc] Remove braces from single-statement ifs as per LLVM code style
overmighty Jun 14, 2024
eb0ff6b
[libc][math] Remove test_special_numbers from FMA MPFR unit test dupl…
overmighty Jun 14, 2024
f3128ee
[libc][math] Update comments in fputil::generic::fma
overmighty Jun 14, 2024
40bd58f
[libc][math] Update comments in fputil::generic::fma again
overmighty Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libc/config/linux/aarch64/entrypoints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
libc.src.math.canonicalizef16
libc.src.math.ceilf16
libc.src.math.copysignf16
libc.src.math.f16fmaf
libc.src.math.f16sqrtf
libc.src.math.fabsf16
libc.src.math.fdimf16
Expand Down
1 change: 1 addition & 0 deletions libc/config/linux/x86_64/entrypoints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
libc.src.math.canonicalizef16
libc.src.math.ceilf16
libc.src.math.copysignf16
libc.src.math.f16fmaf
libc.src.math.f16sqrtf
libc.src.math.fabsf16
libc.src.math.fdimf16
Expand Down
2 changes: 2 additions & 0 deletions libc/docs/math/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ Basic Operations
+------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
| dsub | N/A | N/A | | N/A | | 7.12.14.2 | F.10.11 |
+------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
| f16fma | |check| | | | N/A | | 7.12.14.5 | F.10.11 |
+------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
| fabs | |check| | |check| | |check| | |check| | |check| | 7.12.7.3 | F.10.4.3 |
+------------------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
| fadd | N/A | | | N/A | | 7.12.14.1 | F.10.11 |
Expand Down
3 changes: 2 additions & 1 deletion libc/spec/stdc.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,10 +474,11 @@ def StdC : StandardSpec<"stdc"> {

FunctionSpec<"fmul", RetValSpec<FloatType>, [ArgSpec<DoubleType>, ArgSpec<DoubleType>]>,


FunctionSpec<"fma", RetValSpec<DoubleType>, [ArgSpec<DoubleType>, ArgSpec<DoubleType>, ArgSpec<DoubleType>]>,
FunctionSpec<"fmaf", RetValSpec<FloatType>, [ArgSpec<FloatType>, ArgSpec<FloatType>, ArgSpec<FloatType>]>,

GuardedFunctionSpec<"f16fmaf", RetValSpec<Float16Type>, [ArgSpec<FloatType>, ArgSpec<FloatType>, ArgSpec<FloatType>], "LIBC_TYPES_HAS_FLOAT16">,

FunctionSpec<"fmod", RetValSpec<DoubleType>, [ArgSpec<DoubleType>, ArgSpec<DoubleType>]>,
FunctionSpec<"fmodf", RetValSpec<FloatType>, [ArgSpec<FloatType>, ArgSpec<FloatType>]>,
FunctionSpec<"fmodl", RetValSpec<LongDoubleType>, [ArgSpec<LongDoubleType>, ArgSpec<LongDoubleType>]>,
Expand Down
32 changes: 10 additions & 22 deletions libc/src/__support/FPUtil/FMA.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,41 +10,29 @@
#define LLVM_LIBC_SRC___SUPPORT_FPUTIL_FMA_H

#include "src/__support/CPP/type_traits.h"
#include "src/__support/FPUtil/generic/FMA.h"
#include "src/__support/macros/properties/architectures.h"
#include "src/__support/macros/properties/cpu_features.h" // LIBC_TARGET_CPU_HAS_FMA

#if defined(LIBC_TARGET_CPU_HAS_FMA)

namespace LIBC_NAMESPACE {
namespace fputil {

template <typename T>
LIBC_INLINE cpp::enable_if_t<cpp::is_same_v<T, float>, T> fma(T x, T y, T z) {
return __builtin_fmaf(x, y, z);
template <typename OutType, typename InType>
LIBC_INLINE OutType fma(InType x, InType y, InType z) {
return generic::fma<OutType>(x, y, z);
}

template <typename T>
LIBC_INLINE cpp::enable_if_t<cpp::is_same_v<T, double>, T> fma(T x, T y, T z) {
return __builtin_fma(x, y, z);
#ifdef LIBC_TARGET_CPU_HAS_FMA
template <> LIBC_INLINE float fma(float x, float y, float z) {
return __builtin_fmaf(x, y, z);
}

} // namespace fputil
} // namespace LIBC_NAMESPACE

#else
// FMA instructions are not available
#include "generic/FMA.h"

namespace LIBC_NAMESPACE {
namespace fputil {

template <typename T> LIBC_INLINE T fma(T x, T y, T z) {
return generic::fma(x, y, z);
template <> LIBC_INLINE double fma(double x, double y, double z) {
return __builtin_fma(x, y, z);
}
#endif // LIBC_TARGET_CPU_HAS_FMA

} // namespace fputil
} // namespace LIBC_NAMESPACE

#endif

#endif // LLVM_LIBC_SRC___SUPPORT_FPUTIL_FMA_H
3 changes: 3 additions & 0 deletions libc/src/__support/FPUtil/generic/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,15 @@ add_header_library(
HDRS
FMA.h
DEPENDS
libc.hdr.fenv_macros
libc.src.__support.common
libc.src.__support.CPP.bit
libc.src.__support.CPP.limits
libc.src.__support.CPP.type_traits
libc.src.__support.FPUtil.fenv_impl
libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.rounding_mode
libc.src.__support.big_int
libc.src.__support.macros.optimization
libc.src.__support.uint128
)
Expand Down
Loading