MathExtras: MulOverflow: use builtin when available (NFC)

[Superty]

This matches the other two functions AddOverflow and SubOverflow.

[llvmbot]

@llvm/pr-subscribers-llvm-support

Author: Arjun P (Superty)

Changes

This matches the other two functions AddOverflow and SubOverflow.

---

Full diff: https://github.com/llvm/llvm-project/pull/95046.diff

1 Files Affected:

• (modified) llvm/include/llvm/Support/MathExtras.h (+4)

diff --git a/llvm/include/llvm/Support/MathExtras.h b/llvm/include/llvm/Support/MathExtras.h
index f0e4ee534ece3..adb5ba6e3dcc2 100644
--- a/llvm/include/llvm/Support/MathExtras.h
+++ b/llvm/include/llvm/Support/MathExtras.h
@@ -635,6 +635,9 @@ std::enable_if_t<std::is_signed_v<T>, T> SubOverflow(T X, T Y, T &Result) {
 /// result, returning true if an overflow ocurred.
 template <typename T>
 std::enable_if_t<std::is_signed_v<T>, T> MulOverflow(T X, T Y, T &Result) {
+#if __has_builtin(__builtin_mul_overflow)
+  return __builtin_mul_overflow(X, Y, &Result);
+#else
   // Perform the unsigned multiplication on absolute values.
   using U = std::make_unsigned_t<T>;
   const U UX = X < 0 ? (0 - static_cast<U>(X)) : static_cast<U>(X);
@@ -656,6 +659,7 @@ std::enable_if_t<std::is_signed_v<T>, T> MulOverflow(T X, T Y, T &Result) {
     return UX > (static_cast<U>(std::numeric_limits<T>::max()) + U(1)) / UY;
   else
     return UX > (static_cast<U>(std::numeric_limits<T>::max())) / UY;
+#endif
 }
 
 } // namespace llvm

[kazutakahirata]

LGTM. Thanks!

[joker-eph]

Thanks for tracking this down!

Can we remove the ones that are in MLIR then?

[Superty]

Yeah, we can.