Skip to content

[clang][CodeComplete] Recurse into the subexpression of deref operator in getApproximateType #93404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zyn0217 merged 2 commits into from
May 27, 2024
Merged

[clang][CodeComplete] Recurse into the subexpression of deref operator in getApproximateType #93404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7639cb7
[clang][CodeComplete] Recurse into the subexpression of deref operato…
zyn0217 May 26, 2024
079f964
Address feedback
zyn0217 May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions clang/lib/Sema/SemaCodeComplete.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5680,8 +5680,15 @@ QualType getApproximateType(const Expr *E) {
}
}
if (const auto *UO = llvm::dyn_cast<UnaryOperator>(E)) {
if (UO->getOpcode() == UnaryOperatorKind::UO_Deref)
return UO->getSubExpr()->getType()->getPointeeType();
if (UO->getOpcode() == UnaryOperatorKind::UO_Deref) {
// We recurse into the subexpression because it could be of dependent
// type.
if (auto Pointee = getApproximateType(UO->getSubExpr())->getPointeeType();
!Pointee.isNull())
return Pointee;
// Our caller expects a non-null result, even though the SubType is
// supposed to have a pointee. Fall through to Unresolved anyway.
}
}
return Unresolved;
}
Expand Down
16 changes: 16 additions & 0 deletions clang/test/CodeCompletion/member-access.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,4 +367,20 @@ class A {
// CHECK-DEREF-THIS: [#void#]function()
}
};

template <typename Element>
struct RepeatedField {
void Add();
};

template <typename T>
RepeatedField<T>* MutableRepeatedField() {}

template <class T>
void Foo() {
auto& C = *MutableRepeatedField<T>();
C.
}
// RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:382:5 %s -o - | FileCheck -check-prefix=CHECK-DEREF-DEPENDENT %s
// CHECK-DEREF-DEPENDENT: [#void#]Add()
}