Skip to content

MIPS/Clang: Add more false option pairs into validateTarget #91968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wzssyqa merged 4 commits into from
May 22, 2024
Merged

MIPS/Clang: Add more false option pairs into validateTarget #91968

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cccd960
MIPS/Clang: Add more false option pairs into validateTarget
wzssyqa May 13, 2024
6bea5fc
Merge branch 'main' into validateTarget
wzssyqa May 20, 2024
8303a81
Merge branch 'main' into validateTarget
wzssyqa May 21, 2024
c911c59
Merge branch 'main' into validateTarget
wzssyqa May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions clang/lib/Basic/Targets/Mips.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,34 @@ bool MipsTargetInfo::validateTarget(DiagnosticsEngine &Diags) const {
Diags.Report(diag::err_mips_fp64_req) << "-mfp64";
return false;
}
// FPXX requires mips2+
if (FPMode == FPXX && CPU == "mips1") {
Diags.Report(diag::err_opt_not_valid_with_opt) << "-mfpxx" << CPU;
return false;
}
// -mmsa with -msoft-float makes nonsense
if (FloatABI == SoftFloat && HasMSA) {
Diags.Report(diag::err_opt_not_valid_with_opt) << "-msoft-float"
<< "-mmsa";
return false;
}
// Option -mmsa permitted on Mips32 iff revision 2 or higher is present
if (HasMSA && (CPU == "mips1" || CPU == "mips2" || getISARev() < 2) &&
ABI == "o32") {
Diags.Report(diag::err_mips_fp64_req) << "-mmsa";
return false;
}
// MSA requires FP64
if (FPMode == FPXX && HasMSA) {
Diags.Report(diag::err_opt_not_valid_with_opt) << "-mfpxx"
<< "-mmsa";
return false;
}
if (FPMode == FP32 && HasMSA) {
Diags.Report(diag::err_opt_not_valid_with_opt) << "-mfp32"
<< "-mmsa";
return false;
}

return true;
}