[NFC] Use const& avoiding copies

[SimplyDanny]

Fixes #90285.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Danny Mösch (SimplyDanny)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/90334.diff

1 Files Affected:

• (modified) clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp (+1-1)

diff --git a/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp b/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
index d58f5bb0919906..f8dced5dbafb60 100644
--- a/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
+++ b/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
@@ -295,7 +295,7 @@ class InterfaceStubFunctionsConsumer : public ASTConsumer {
       OS << "Symbols:\n";
       for (const auto &E : Symbols) {
         const MangledSymbol &Symbol = E.second;
-        for (auto Name : Symbol.Names) {
+        for (const auto &Name : Symbol.Names) {
           OS << "  - { Name: \""
              << (Symbol.ParentName.empty() || Instance.getLangOpts().CPlusPlus
                      ? ""

[SimplyDanny]

The failing Windows tests seem to be related to my change, yet I can't see what actually failed. Can you help me figure out what's wrong, @lipracer?

[lipracer]

This change seems to be unrelated to the platform, and I don't think it's the change that caused the CI error. From the compiled log, it seems that there is not enough memory space.

[SimplyDanny]

This change seems to be unrelated to the platform, and I don't think it's the change that caused the CI error. From the compiled log, it seems that there is not enough memory space.

Okay, that's good news. I wasn't sure because I've not found any other builds to fail like this and mine reported failure twice. But indeed I face the same excessive RAM consumption when building the flang target locally on main.