Skip to content

[libc][msan] Fix "non-constexpr function '__msan_unpoison' cannot be used in a constant expression" #88719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[libc][msan] Fix "non-constexpr function '__msan_unpoison' cannot be used in a constant expression" #88719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03a8e91
[libc][msan] Fix "non-constexpr function '__msan_unpoison' cannot be …
gchatelet Apr 15, 2024
0b164f4
remove `constexpr` and associated pragmas
gchatelet Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions libc/src/__support/macros/sanitizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,13 @@
// Functions to unpoison memory
//-----------------------------------------------------------------------------

#if defined(LIBC_HAVE_MEMORY_SANITIZER) && __has_builtin(__builtin_constant_p)
#if defined(LIBC_HAVE_MEMORY_SANITIZER)
// Only perform MSAN unpoison in non-constexpr context.
#include <sanitizer/msan_interface.h>
#define MSAN_UNPOISON(addr, size) \
do { \
if (!__builtin_constant_p(*addr)) { \
if (!__builtin_is_constant_evaluated()) \
__msan_unpoison(addr, size); \
} \
} while (0)
#else
#define MSAN_UNPOISON(ptr, size)
Expand Down