Skip to content

[RISCV] Precommit stack protector checks for Linux and Android #87679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2024
Merged

[RISCV] Precommit stack protector checks for Linux and Android #87679

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c35a29f
[𝘀𝗽𝗿] changes to main this commit is based on
ilovepi Apr 4, 2024
54f8681
[𝘀𝗽𝗿] initial version
ilovepi Apr 4, 2024
90dc9ac
rebase
ilovepi Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions llvm/test/CodeGen/RISCV/stack-protector-target.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,32 @@

;; Test target-specific stack cookie location.
;
; RUN: llc -mtriple=riscv64-linux < %s | FileCheck --check-prefix=LINUX-RISCV64 %s
; RUN: llc -mtriple=riscv64-fuchsia < %s | FileCheck --check-prefix=FUCHSIA-RISCV64 %s
; RUN: llc -mtriple=riscv64-android < %s | FileCheck --check-prefix=ANDROID-RISCV64 %s

define void @func() sspreq nounwind {
; LINUX-RISCV64-LABEL: func:
; LINUX-RISCV64: # %bb.0:
; LINUX-RISCV64-NEXT: addi sp, sp, -32
; LINUX-RISCV64-NEXT: sd ra, 24(sp) # 8-byte Folded Spill
; LINUX-RISCV64-NEXT: sd s0, 16(sp) # 8-byte Folded Spill
; LINUX-RISCV64-NEXT: lui s0, %hi(__stack_chk_guard)
; LINUX-RISCV64-NEXT: ld a0, %lo(__stack_chk_guard)(s0)
; LINUX-RISCV64-NEXT: sd a0, 8(sp)
; LINUX-RISCV64-NEXT: addi a0, sp, 4
; LINUX-RISCV64-NEXT: call capture
; LINUX-RISCV64-NEXT: ld a0, %lo(__stack_chk_guard)(s0)
; LINUX-RISCV64-NEXT: ld a1, 8(sp)
; LINUX-RISCV64-NEXT: bne a0, a1, .LBB0_2
; LINUX-RISCV64-NEXT: # %bb.1:
; LINUX-RISCV64-NEXT: ld ra, 24(sp) # 8-byte Folded Reload
; LINUX-RISCV64-NEXT: ld s0, 16(sp) # 8-byte Folded Reload
; LINUX-RISCV64-NEXT: addi sp, sp, 32
; LINUX-RISCV64-NEXT: ret
; LINUX-RISCV64-NEXT: .LBB0_2:
; LINUX-RISCV64-NEXT: call __stack_chk_fail
;
; FUCHSIA-RISCV64-LABEL: func:
; FUCHSIA-RISCV64: # %bb.0:
; FUCHSIA-RISCV64-NEXT: addi sp, sp, -32
Expand All @@ -22,6 +45,27 @@ define void @func() sspreq nounwind {
; FUCHSIA-RISCV64-NEXT: ret
; FUCHSIA-RISCV64-NEXT: .LBB0_2: # %CallStackCheckFailBlk
; FUCHSIA-RISCV64-NEXT: call __stack_chk_fail
;
; ANDROID-RISCV64-LABEL: func:
; ANDROID-RISCV64: # %bb.0:
; ANDROID-RISCV64-NEXT: addi sp, sp, -32
; ANDROID-RISCV64-NEXT: sd ra, 24(sp) # 8-byte Folded Spill
; ANDROID-RISCV64-NEXT: sd s0, 16(sp) # 8-byte Folded Spill
; ANDROID-RISCV64-NEXT: lui s0, %hi(__stack_chk_guard)
; ANDROID-RISCV64-NEXT: ld a0, %lo(__stack_chk_guard)(s0)
; ANDROID-RISCV64-NEXT: sd a0, 8(sp)
; ANDROID-RISCV64-NEXT: addi a0, sp, 4
; ANDROID-RISCV64-NEXT: call capture
; ANDROID-RISCV64-NEXT: ld a0, %lo(__stack_chk_guard)(s0)
; ANDROID-RISCV64-NEXT: ld a1, 8(sp)
; ANDROID-RISCV64-NEXT: bne a0, a1, .LBB0_2
; ANDROID-RISCV64-NEXT: # %bb.1:
; ANDROID-RISCV64-NEXT: ld ra, 24(sp) # 8-byte Folded Reload
; ANDROID-RISCV64-NEXT: ld s0, 16(sp) # 8-byte Folded Reload
; ANDROID-RISCV64-NEXT: addi sp, sp, 32
; ANDROID-RISCV64-NEXT: ret
; ANDROID-RISCV64-NEXT: .LBB0_2:
; ANDROID-RISCV64-NEXT: call __stack_chk_fail
%1 = alloca i32, align 4
call void @capture(ptr %1)
ret void
Expand Down