Skip to content

[tsan] Set thr->is_inited after SlotAttachAndLock #86342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2024
Merged

[tsan] Set thr->is_inited after SlotAttachAndLock #86342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f016ccb
[𝘀𝗽𝗿] changes to main this commit is based on
vitalybuka Mar 22, 2024
a1fcd65
[𝘀𝗽𝗿] initial version
vitalybuka Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions compiler-rt/lib/tsan/rtl/tsan_rtl_thread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ void ThreadStart(ThreadState *thr, Tid tid, tid_t os_id,
}
Free(thr->tctx->sync);

#if !SANITIZER_GO
thr->is_inited = true;
#endif

uptr stk_addr = 0;
uptr stk_size = 0;
uptr tls_addr = 0;
Expand Down Expand Up @@ -200,15 +204,11 @@ void ThreadStart(ThreadState *thr, Tid tid, tid_t os_id,
}

void ThreadContext::OnStarted(void *arg) {
thr = static_cast<ThreadState *>(arg);
DPrintf("#%d: ThreadStart\n", tid);
new (thr) ThreadState(tid);
thr = new (arg) ThreadState(tid);
if (common_flags()->detect_deadlocks)
thr->dd_lt = ctx->dd->CreateLogicalThread(tid);
thr->tctx = this;
#if !SANITIZER_GO
thr->is_inited = true;
#endif
}

void ThreadFinish(ThreadState *thr) {
Expand Down