Skip to content

[sanitizer][windows] report symbols in clang_rt. or \compiler-rt\lib\ as internal. #84971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[sanitizer][windows] report symbols in clang_rt. or \compiler-rt\lib\ as internal. #84971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,12 @@ static bool FrameIsInternal(const SymbolizedStack *frame) {
internal_strstr(file, "/include/c++/") ||
internal_strstr(file, "/include/g++")))
return true;
if (file && internal_strstr(file, "\\compiler-rt\\lib\\"))
return true;
if (module && (internal_strstr(module, "libclang_rt.")))
return true;
if (module && (internal_strstr(module, "clang_rt.")))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is libclang_rt. redundant then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean not if you happened to build the library with that name....

It might show up for cygwin or mingw builds. I don't see a reason to do platform specific preprocessing here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new if (module && (internal_strstr(module, "clang_rt."))) will match existing libclang

return true;
return false;
}

Expand Down