Skip to content

[NVPTX][DebugInfo] avoid emitting extra .loc directives #84584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[NVPTX][DebugInfo] avoid emitting extra .loc directives #84584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e70681
[NVPTX][DebugInfo] avoid emitting extra .loc directives
AlexMaclean Mar 8, 2024
8e5500b
address comments
AlexMaclean Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,11 @@ void NVPTXAsmPrinter::emitFunctionEntryLabel() {
OutStreamer->emitRawText(StringRef("{\n"));
setAndEmitFunctionVirtualRegisters(*MF);
// Emit initial .loc debug directive for correct relocation symbol data.
if (MMI && MMI->hasDebugInfo())
emitInitialRawDwarfLocDirective(*MF);
if (const DISubprogram *SP = MF->getFunction().getSubprogram()) {
assert(SP->getUnit());
if (!SP->getUnit()->isDebugDirectivesOnly() && MMI && MMI->hasDebugInfo())
emitInitialRawDwarfLocDirective(*MF);
}
}

bool NVPTXAsmPrinter::runOnMachineFunction(MachineFunction &F) {
Expand Down
26 changes: 26 additions & 0 deletions llvm/test/DebugInfo/NVPTX/no-extra-loc.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
; RUN: llc < %s -mtriple=nvptx64-nvidia-cuda | FileCheck %s
; RUN: %if ptxas %{ llc < %s -mtriple=nvptx64-nvidia-cuda | %ptxas-verify %}


define i32 @foo(i32 %a, i32 %b) !dbg !3 {

; CHECK: .loc [[FILE:[0-9]+]] 26 0 // extra-lineinfo.cu:26:0
; CHECK-NOT: .loc [[FILE]] 26 0 // extra-lineinfo.cu:26:0
; CHECK: .file [[FILE]] "/test/directory/extra-lineinfo.cu"

%add = add i32 %b, %a, !dbg !6
ret i32 %add, !dbg !6
}

!llvm.dbg.cu = !{!0}
!nvvm.annotations = !{}
!llvm.module.flags = !{!2}

!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang", isOptimized: true, runtimeVersion: 0, emissionKind: DebugDirectivesOnly)
!1 = !DIFile(filename: "extra-lineinfo.cu", directory: "/test/directory/")
!2 = !{i32 1, !"Debug Info Version", i32 3}
!3 = distinct !DISubprogram(name: "kernel", linkageName: "foo", scope: !1, file: !1, line: 123, type: !4, scopeLine: 26, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0)
!4 = !DISubroutineType(types: !5)
!5 = !{}
!6 = !DILocation(line: 40, column: 22, scope: !31)
!31 = distinct !DILexicalBlock(scope: !3, file: !1, line: 3, column: 17)