[libc++][test] Don't include test_format_context.h in parse.pass.cpp
#83734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/parse.pass.cpp` The test doesn't need to call `test_format_context_create` to create a `basic_format_context`, so it shouldn't include `test_format_context.h`. Discovered when implementing `formatter<tuple>` in MSVC STL. With the inclusion removed, local test passes when using enhanced MSVC STL.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: A. Jiang (frederick-vs-ja) ChangesThe test doesn't need to call Discovered when implementing Full diff: https://github.com/llvm/llvm-project/pull/83734.diff 1 Files Affected:
diff --git a/libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp b/libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp
index 5cabbda63dd02e..313f8ef8d220d0 100644
--- a/libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.tuple/parse.pass.cpp
@@ -27,7 +27,6 @@
#include <tuple>
#include <utility>
-#include "test_format_context.h"
#include "test_macros.h"
#include "make_string.h"
|
mordante
reviewed
Mar 3, 2024
frederick-vs-ja
changed the title
test_format_context.h in format.tuple/parse.pass.cpptest_format_context.h in parse.pass.cpp
And consistently use `assert(std::to_address(it) == std::to_address(fmt.end()) - offset)` due to LWG3989
|
Merging. The CI failures are flukes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parse.pass.cpptests doen't need to calltest_format_context_createto create abasic_format_context, so they shouldn't includetest_format_context.h.The
to_addressmechanism works around the iterator debugging mechanisms of MSVC STL. Related to LWG3989.Discovered when implementing
formatter<tuple>in MSVC STL. With the inclusion removed,std/utilities/format/format.tuple/parse.pass.cppwhen using enhanced MSVC STL (and/utf-8option for MSVC).