Skip to content

[clang][sema] Fix -Wunused-function on target_version'd file-scope Fn's #81167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2024
Merged

[clang][sema] Fix -Wunused-function on target_version'd file-scope Fn's #81167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e3020
[clang][sema] Fix -Wunused-function on target_version'd file-scope fu…
jroelofs Feb 8, 2024
6d2def5
clang-format
jroelofs Feb 8, 2024
c7bf75e
Merge branch 'main' into jroelofs/local-fmv
jroelofs Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clang/include/clang/AST/Decl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2615,6 +2615,10 @@ class FunctionDecl : public DeclaratorDecl,
/// the target functionality.
bool isTargetMultiVersion() const;

/// True if this function is the default version of a multiversioned dispatch
/// function as a part of the target functionality.
bool isTargetMultiVersionDefault() const;

/// True if this function is a multiversioned dispatch function as a part of
/// the target-clones functionality.
bool isTargetClonesMultiVersion() const;
Expand Down
5 changes: 5 additions & 0 deletions clang/lib/AST/Decl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3537,6 +3537,11 @@ bool FunctionDecl::isTargetMultiVersion() const {
(hasAttr<TargetAttr>() || hasAttr<TargetVersionAttr>());
}

bool FunctionDecl::isTargetMultiVersionDefault() const {
return isMultiVersion() && hasAttr<TargetVersionAttr>() &&
getAttr<TargetVersionAttr>()->isDefaultVersion();
}

bool FunctionDecl::isTargetClonesMultiVersion() const {
return isMultiVersion() && hasAttr<TargetClonesAttr>();
}
Expand Down
3 changes: 2 additions & 1 deletion clang/lib/Sema/Sema.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,7 +1393,8 @@ void Sema::ActOnEndOfTranslationUnit() {
Diag(DiagD->getLocation(), diag::warn_unneeded_internal_decl)
<< /*function=*/0 << DiagD << DiagRange;
}
} else {
} else if (!FD->isTargetMultiVersion() ||
FD->isTargetMultiVersionDefault()) {
if (FD->getDescribedFunctionTemplate())
Diag(DiagD->getLocation(), diag::warn_unused_template)
<< /*function=*/0 << DiagD << DiagRange;
Expand Down
16 changes: 16 additions & 0 deletions clang/test/SemaCXX/warn-unused-filescoped.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,4 +236,20 @@ constexpr int constexpr4() { return 2; }
#endif
}

__attribute__((target_version("fp16")))
static int not_used_fmv(void) { return 1; }
__attribute__((target_version("fp16fml")))
static int not_used_fmv(void) { return 2; }
__attribute__((target_version("default")))
static int not_used_fmv(void) { return 0; } // expected-warning {{unused function 'not_used_fmv'}}


__attribute__((target_version("fp16")))
static int definitely_used_fmv(void) { return 1; }
__attribute__((target_version("fp16fml")))
static int definitely_used_fmv(void) { return 2; }
__attribute__((target_version("default")))
static int definitely_used_fmv(void) { return 0; }
int definite_user(void) { return definitely_used_fmv(); }

#endif