Skip to content

[Sanitizers][ABI] Build ASAN shim for arm64_32 arch #81066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

[Sanitizers][ABI] Build ASAN shim for arm64_32 arch #81066

merged 1 commit into from
Feb 12, 2024

Conversation

wrotki
Copy link
Contributor

@wrotki wrotki commented Feb 8, 2024

Turns out this arch is needed by the ABI impls

rdar://121963634

[Sanitizers][ABI] Build ASAN shim for arm64_32 arch
02df48b 
Turns out this arch is needed by the ABI impls

rdar://121963634
@thetruestblue
Copy link
Contributor

thetruestblue commented Feb 8, 2024 •
edited
Loading

Are no changes needed in asan_abi cmakes files?

If we want to test shim tests on all archs the test file checks for archs explicitly:

macro(get_bits_for_arch arch bits)
  if (${arch} MATCHES "arm64|x86_64")
    set(${bits} 64)
  else()
    message(FATAL_ERROR "Unknown target architecture: ${arch}")
  endif()
endmacro()

@wrotki wrotki merged commit d9c3066 into llvm:main Feb 12, 2024
@wrotki wrotki deleted the build_abi_for_arm64_32 branch February 12, 2024 18:46
wrotki added a commit to swiftlang/llvm-project that referenced this pull request Feb 13, 2024
@wrotki
[Sanitizers][ABI] Build ASAN shim for arm64_32 arch (llvm#81066)
0a7030b 
Turns out this arch is needed by the ABI impls

rdar://121963634

Co-authored-by: Mariusz Borsa <[email protected]>
(cherry picked from commit d9c3066)
wrotki added a commit to swiftlang/llvm-project that referenced this pull request Feb 14, 2024
@wrotki
Merge pull request #8188 from apple/m_borsa/cherry-pick-d9c3066
f9f0e96 
[Sanitizers][ABI] Build ASAN shim for arm64_32 arch (llvm#81066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yln yln yln approved these changes

@thetruestblue thetruestblue thetruestblue approved these changes

@rsundahl rsundahl Awaiting requested review from rsundahl

@devincoughlin devincoughlin Awaiting requested review from devincoughlin

Assignees
No one assigned
Labels
compiler-rt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wrotki @thetruestblue @yln @llvmbot