-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[Github Automation] Update Execute command #81002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Taken account of these strings :
|
Error: Command failed due to missing milestone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! I think it looks good, but I leave it to @tstellar to make the final call.
ping |
ping @AaronBallman @nikic |
This is a rather trivial issue. If this is not relevant anymore, I will close the PR and you can mark the issue as resolved. Though I do think that adding regex support for cherry-pick seems prudent. |
I think this is fine, but maybe remove the comment about the obsolete /branch command in another patch. |
I think we can do that in this PR itself. Removing the branch command and adding regex support for the chery-pick command ? |
OK, that's fine. |
I have made some changes in the comments, and since the command will always be cherry-pick now, removed the if statement also. I don't think this can particularly cause a build fail, might be safe to land this without waiting for CI build workflow. Updated the PR Summary and header as well. |
Hm.. Some Flang test is failing. I know that the build process on Windows is a little buggy. I leave the rest to your discretion. @tstellar |
@tstellar, should I pass an empty commit to retrigger the checks? |
✅ With the latest revision this PR passed the Python code formatter. |
Fixes: #64803
PR SUMMARY: Removed unsupported branch command and changed Regex to accept /cherry-pick: command.