-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Accept /branch: and /cherry-pick: commands #64803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
For more instructions on how to submit a patch to LLVM, see our documentation. If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue. @llvm/issue-subscribers-good-first-issue |
@llvm/issue-subscribers-infrastructure |
Error: Command failed due to missing milestone. |
Hey, I'm new to llvm and fairly competent with python. I'd love to take this up. I think I see the issue in the file mentioned. What is the expected behaviour here exactly? Currently, I see that the implemented regex does not support having colons in the command, only lowercase letters and hyphens. Are colons the only thing we are looking to support or is there anything else? |
Only colons is fine for now. |
Hi , is the issue still open. I am fairly new to LLVM, but decently proficent in Python and would like to try to resolve this issue. Can this issue be assigned to me please? Thanks. |
Hello, I looked at the issue and I believe I can solve it. Can you please assign me the issue, @tbaederr. |
Fixes: #64803 Removed unsupported branch command and changed Regex to accept /cherry-pick: command.
This is implemented in
llvm/utils/git/github-automation.py
.People can't write
/cherry-pick: foobar
, because the colon breaks the script. The same is true for/branch
.The text was updated successfully, but these errors were encountered: