-
Notifications
You must be signed in to change notification settings - Fork 14.6k
[X86] Add missing MACROs in cpuid.h #80815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can test this locally with the following command:git-clang-format --diff 4b34558f43121df9b863ff2492f74fb2e65a5af1 fd0c860aab3c78505222c281419a366a36104e37 -- clang/lib/Headers/cpuid.h View the diff from clang-format here.diff --git a/clang/lib/Headers/cpuid.h b/clang/lib/Headers/cpuid.h
index c968d37fb8..bc13af54f6 100644
--- a/clang/lib/Headers/cpuid.h
+++ b/clang/lib/Headers/cpuid.h
@@ -200,9 +200,9 @@
#define bit_AMXINT8 0x02000000
/* Features in %eax for leaf 7 sub-leaf 1 */
-#define bit_SHA512 0x00000001
-#define bit_SM3 0x00000002
-#define bit_SM4 0x00000004
+#define bit_SHA512 0x00000001
+#define bit_SM3 0x00000002
+#define bit_SM4 0x00000004
#define bit_RAOINT 0x00000008
#define bit_AVXVNNI 0x00000010
#define bit_AVX512BF16 0x00000020
@@ -214,11 +214,11 @@
/* Features in %edx for leaf 7 sub-leaf 1 */
#define bit_AVXVNNIINT8 0x00000010
#define bit_AVXNECONVERT 0x00000020
-#define bit_AMXCOMPLEX 0x00000100
-#define bit_AVXVNNIINT16 0x00000400
+#define bit_AMXCOMPLEX 0x00000100
+#define bit_AVXVNNIINT16 0x00000400
#define bit_PREFETCHI 0x00004000
-#define bit_USERMSR 0x00008000
-#define bit_AVX10 0x00080000
+#define bit_USERMSR 0x00008000
+#define bit_AVX10 0x00080000
/* Features in %eax for leaf 13 sub-leaf 1 */
#define bit_XSAVEOPT 0x00000001
@@ -252,8 +252,8 @@
#define bit_WBNOINVD 0x00000200
/* Features in %ebx for leaf 0x24 */
-#define bit_AVX10_256 0x00020000
-#define bit_AVX10_512 0x00040000
+#define bit_AVX10_256 0x00020000
+#define bit_AVX10_512 0x00040000
#if __i386__
#define __cpuid(__leaf, __eax, __ebx, __ecx, __edx) \
|
@llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang Author: Freddy Ye (FreddyLeaf) ChangesFull diff: https://github.com/llvm/llvm-project/pull/80815.diff 1 Files Affected:
diff --git a/clang/lib/Headers/cpuid.h b/clang/lib/Headers/cpuid.h
index 1ad6853a97c9d2..1f3e28a3bfa61b 100644
--- a/clang/lib/Headers/cpuid.h
+++ b/clang/lib/Headers/cpuid.h
@@ -200,6 +200,9 @@
#define bit_AMXINT8 0x02000000
/* Features in %eax for leaf 7 sub-leaf 1 */
+#define bit_SHA512 0x00000001
+#define bit_SM3 0x00000002
+#define bit_SM4 0x00000004
#define bit_RAOINT 0x00000008
#define bit_AVXVNNI 0x00000010
#define bit_AVX512BF16 0x00000020
@@ -211,7 +214,11 @@
/* Features in %edx for leaf 7 sub-leaf 1 */
#define bit_AVXVNNIINT8 0x00000010
#define bit_AVXNECONVERT 0x00000020
+#define bit_AMXCOMPLEX 0x00000100
+#define bit_AVXVNNIINT16 0x00000400
#define bit_PREFETCHI 0x00004000
+#define bit_USERMSR 0x00008000
+#define bit_AVX10_256 0x00080000
/* Features in %eax for leaf 13 sub-leaf 1 */
#define bit_XSAVEOPT 0x00000001
@@ -244,6 +251,8 @@
#define bit_RDPRU 0x00000010
#define bit_WBNOINVD 0x00000200
+/* Features in %ebx for leaf 0x24 */
+#define bit_AVX10_512 0x00040000
#if __i386__
#define __cpuid(__leaf, __eax, __ebx, __ecx, __edx) \
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Past the link of GCC files in description?
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks review! |
Relate gcc file: https://github.com/gcc-mirror/gcc/blob/master/gcc/config/i386/cpuid.h