Skip to content

[libc++] Add clang-19 to failing tests on Windows #79619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2024
Merged

[libc++] Add clang-19 to failing tests on Windows #79619

merged 1 commit into from
Jan 26, 2024

Conversation

gulfemsavrun
Copy link
Contributor

After trunk is bumped to version 19, some libc++ tests started failing on Windows. This patch adds clang-19 condition to XFAIL to fix the issue.

@gulfemsavrun
[libc++] Add clang-19 to failing tests on Windows
fa64f0b 
After trunk is bumped to version 19, some libc++ tests started
failing on Windows. This patch adds clang-19 condition to XFAIL
to fix the issue.
@gulfemsavrun gulfemsavrun requested a review from a team as a code owner January 26, 2024 16:51
@gulfemsavrun gulfemsavrun requested review from petrhosek and removed request for a team January 26, 2024 16:51
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 26, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 26, 2024

@llvm/pr-subscribers-libcxx

Author: None (gulfemsavrun)

Changes

After trunk is bumped to version 19, some libc++ tests started failing on Windows. This patch adds clang-19 condition to XFAIL to fix the issue.

Full diff: https://github.com/llvm/llvm-project/pull/79619.diff

3 Files Affected:

  • (modified) libcxx/test/libcxx/fuzzing/random.pass.cpp (+1-1)
  • (modified) libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp (+1-1)
  • (modified) libcxx/test/std/numerics/c.math/cmath.pass.cpp (+1-1)
diff --git a/libcxx/test/libcxx/fuzzing/random.pass.cpp b/libcxx/test/libcxx/fuzzing/random.pass.cpp
index 69b496fa3a4e66..663977696f2df8 100644
--- a/libcxx/test/libcxx/fuzzing/random.pass.cpp
+++ b/libcxx/test/libcxx/fuzzing/random.pass.cpp
@@ -8,7 +8,7 @@
 
 // This test fails because Clang no longer enables -fdelayed-template-parsing
 // by default on Windows with C++20 (#69431).
-// XFAIL: msvc && clang-18
+// XFAIL: msvc && (clang-18 || clang-19)
 
 // UNSUPPORTED: c++03, c++11
 
diff --git a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
index 7a6c71ae68f797..bbfb0c5548fab6 100644
--- a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
+++ b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
@@ -8,7 +8,7 @@
 
 // This test fails because Clang no longer enables -fdelayed-template-parsing
 // by default on Windows with C++20 (#69431).
-// XFAIL: msvc && clang-18
+// XFAIL: msvc && (clang-18 || clang-19)
 
 // <math.h>
 
diff --git a/libcxx/test/std/numerics/c.math/cmath.pass.cpp b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
index a6a9dad639cdff..93790844997923 100644
--- a/libcxx/test/std/numerics/c.math/cmath.pass.cpp
+++ b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
@@ -8,7 +8,7 @@
 
 // This test fails because Clang no longer enables -fdelayed-template-parsing
 // by default on Windows with C++20 (#69431).
-// XFAIL: msvc && clang-18
+// XFAIL: msvc && (clang-18 || clang-19)
 
 // <cmath>

@gulfemsavrun gulfemsavrun requested a review from ldionne January 26, 2024 16:52
@Zingam
Copy link
Contributor

Zingam commented Jan 26, 2024 •
edited
Loading

The clang-cl tests fail to build randomly with (could this be related to the bump):

<html>
<body>
<!--StartFragment-->
static\test\std\containers\sequences\deque\deque.cons\Output\op_equal.pass.cpp.dir\t.tmp.exe'
--
  | # .---command stderr------------
  | # \| Traceback (most recent call last):
  | # \|   File "C:\ws\src\libcxx\utils\run.py", line 72, in <module>
  | # \|     exit(main())
  | # \|   File "C:\ws\src\libcxx\utils\run.py", line 68, in main
  | # \|     return subprocess.call(commandLine, cwd=args.execdir, env=env, shell=False)
  | # \|   File "c:\python39\lib\subprocess.py", line 349, in call
  | # \|     with Popen(*popenargs, **kwargs) as p:
  | # \|   File "c:\python39\lib\subprocess.py", line 951, in __init__
  | # \|     self._execute_child(args, executable, preexec_fn, close_fds,
  | # \|   File "c:\python39\lib\subprocess.py", line 1420, in _execute_child
  | # \|     hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
  | # \| OSError: [WinError 225] Operation did not complete successfully because the file contains a virus or potentially unwanted software
  | # `-----------------------------
  | # error: command failed with exit status: 1

<!--EndFragment-->
</body>
</html>

or

<html>
<body>
<!--StartFragment-->
DCMAKE_BUILD_TYPE=Debug
--
  | CMake Error at C:/BuildTools/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeDetermineCompilerId.cmake:777 (file):
  | file STRINGS file
  | "C:/ws/src/build/clang-cl-debug/CMakeFiles/3.20.21032501-MSVC_2/CompilerIdC/CMakeCCompilerId.exe"
  | cannot be read.
  | Call Stack (most recent call first):
  | C:/BuildTools/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeDetermineCompilerId.cmake:11 (CMAKE_DETERMINE_COMPILER_ID_CHECK)
  | C:/BuildTools/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeDetermineCompilerId.cmake:58 (__determine_compiler_id_test)
  | C:/BuildTools/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeDetermineCCompiler.cmake:118 (CMAKE_DETERMINE_COMPILER_ID)
  | CMakeLists.txt:9 (project)

<!--EndFragment-->
</body>
</html>

For example:
https://buildkite.com/llvm-project/libcxx-ci/builds/33242#018d455f-544a-46f2-9149-14c35452b77a
https://buildkite.com/llvm-project/libcxx-ci/builds/33240#018d4473-a6f4-45ac-87f2-c9d0ac50c659

ldionne
ldionne approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- this is the kind of thing I would expect when bumping the version.

@ldionne ldionne merged commit 59f0523 into llvm:main Jan 26, 2024
@Zingam Zingam mentioned this pull request Jan 26, 2024
Merged
@H-G-Hristov H-G-Hristov mentioned this pull request Jan 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldionne ldionne ldionne approved these changes

@petrhosek petrhosek Awaiting requested review from petrhosek

Assignees
No one assigned
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gulfemsavrun @llvmbot @Zingam @ldionne