Skip to content

[libc++][modules] Fixes clang-tidy exports. #76288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[libc++][modules] Fixes clang-tidy exports. #76288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion libcxx/test/tools/clang_tidy_checks/header_exportable_declarations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,13 @@ static bool is_global_name_exported_by_std_module(std::string_view name) {

static bool is_valid_declaration_context(
const clang::NamedDecl& decl, std::string_view name, header_exportable_declarations::FileType file_type) {
if (decl.getDeclContext()->isNamespace())
const clang::DeclContext& context = *decl.getDeclContext();
if (context.isNamespace())
return true;

if (context.isFunctionOrMethod() || context.isRecord())
return false;

if (is_global_name_exported_by_std_module(name))
return true;

Expand Down