Skip to content

[Clang] Fix a crash when incorrectly calling an explicit object member function template #75913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2023
Merged

[Clang] Fix a crash when incorrectly calling an explicit object member function template #75913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba38db9
[Clang] Fix a crash when incorrectly calling an explicit object membe…
cor3ntin Dec 19, 2023
b4c0760
use cast instead of dyn_cast
cor3ntin Dec 19, 2023
9231e79
add a const
cor3ntin Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/Sema/SemaExprMember.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,9 @@ static void diagnoseInstanceReference(Sema &SemaRef,
SemaRef.Diag(Loc, diag::err_member_call_without_object)
<< Range << /*static*/ 0;
else {
const auto *Callee = dyn_cast<CXXMethodDecl>(Rep);
if (const auto *Tpl = dyn_cast<FunctionTemplateDecl>(Rep))
Rep = Tpl->getTemplatedDecl();
const auto *Callee = cast<CXXMethodDecl>(Rep);
auto Diag = SemaRef.Diag(Loc, diag::err_member_call_without_object)
<< Range << Callee->isExplicitObjectMemberFunction();
if (!Replacement.empty())
Expand Down
10 changes: 10 additions & 0 deletions clang/test/SemaCXX/cxx2b-deducing-this.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,3 +626,13 @@ void test() {
}

}


namespace GH75732 {
auto serialize(auto&& archive, auto&& c){ }
struct D {
auto serialize(this auto&& self, auto&& archive) {
serialize(archive, self); // expected-error {{call to explicit member function without an object argument}}
}
};
}