[clang][Sema] Resolving Inconsistent Arguments Panic in Variadic Template Variables #70280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
knightXun
changed the title
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Contributor
Author
|
i will add test case for it |
Contributor
|
@knightXun code looks reasonable, ping me when you have tests and a release note :) |
Contributor
Author
|
…iadic Template Variables When template variables are variadic, sema may panic, potentially leading to a situation where the number of function variables exceeds the number of template variables. The sema compares the template signature and function signature parameters one by one, which can trigger an assertion error. This PR, when encountering variadic templates, avoids comparing the template signature and function signature parameters one by one. issue: llvm#70191
Contributor
Author
|
cc @cor3ntin |
cor3ntin
approved these changes
Apr 4, 2024
clang/test/SemaCXX/GH70280.cpp
Outdated
| template <typename... c> void d(c...) = d<b, a>(0, ""); // expected-error {{no matching function for call to 'd'}} | ||
| // expected-error@-1 {{illegal initializer (only variables can be initialized)}} | ||
| // expected-note@-2 {{candidate function template not viable: no known conversion from 'const char[1]' to 'a' (aka 'int') for 2nd argument}} | ||
| } No newline at end of file |
Contributor
|
@shafik Yes. It needs to be rebased though |
Contributor
|
Fixed by 7a28a5b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When template variables are variadic, sema may panic, potentially leading to a situation where the number of function variables exceeds the number of template variables.The sema compares the template signature and function signature parameters one by one, which can trigger an assertion error. This PR, when encountering variadic templates,
avoids comparing the template signature and function signature parameters one by one.
#70191