Skip to content

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Oct 14, 2023

We have moved to clang-tidy 17 now, so the workaround shouldn't be necessary.

@ldionne ldionne requested a review from a team as a code owner October 14, 2023 00:15
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 14, 2023
@llvmbot
Copy link
Member

llvmbot commented Oct 14, 2023

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

We have moved to clang-tidy 17 now, so the workaround shouldn't be necessary.


Full diff: https://github.com/llvm/llvm-project/pull/69035.diff

1 Files Affected:

  • (modified) libcxx/utils/libcxx/test/params.py (-5)
diff --git a/libcxx/utils/libcxx/test/params.py b/libcxx/utils/libcxx/test/params.py
index 456794b9b1cce95..0c043cc6e55ccee 100644
--- a/libcxx/utils/libcxx/test/params.py
+++ b/libcxx/utils/libcxx/test/params.py
@@ -77,11 +77,6 @@
 
 
 def getStdFlag(cfg, std):
-    # TODO(LLVM-17) Remove this clang-tidy-16 work-around
-    if std == "c++23":
-        std = "c++2b"
-    if hasCompileFlag(cfg, "-std=" + std):
-        return "-std=" + std
     # TODO(LLVM-19) Remove the fallbacks needed for Clang 16.
     fallbacks = {
         "c++23": "c++2b",

…code

We have moved to clang-tidy 17 now, so the workaround shouldn't
be necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants