Skip to content

[mlir][sparse] fix unused variable warning on release build #68824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[mlir][sparse] fix unused variable warning on release build #68824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,8 @@ struct SparseSortCOOConverter : public OpConversionPattern<ConvertOp> {

// Otherwise we need another data shuffle and a non-identity map.
assert(dstStt.hasSameDimToLvl(srcStt));
(void)dstStt; // to silence warning when assertion is disabled

auto id = AffineMap::getMultiDimIdentityMap(srcStt.getLvlRank(), ctx);

rewriter.create<SortOp>(loc, nnz, crd, ValueRange{val}, id,
Expand Down
2 changes: 2 additions & 0 deletions mlir/lib/Dialect/SparseTensor/Transforms/StageSparseOperations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ struct StageUnorderedConvert : public OpRewritePattern<ConvertOp> {
// source -> coo
// The tmp COO must be unordered, otherwise it is a direct conversion.
assert(!(srcStt.hasSameDimToLvl(dstStt) && srcStt.isAllOrdered()));
(void)srcStt; // to silence warning when assertion is disabled

Type srcCOOTp = getCOOFromTypeWithOrdering(
dstStt.getRankedTensorType(), dstStt.getDimToLvl(), /*ordered=*/false);
Value srcCOO = rewriter.create<ConvertOp>(loc, srcCOOTp, op.getSource());
Expand Down