Skip to content

[llvm][Support] fix convertToSnakeFromCamelCase #68375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2023
Merged

[llvm][Support] fix convertToSnakeFromCamelCase #68375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84ac205
[llvm][Support] fix convertToSnakeFromCamelCase
makslevental Oct 6, 2023
f005c3b
hoist regexes
makslevental Oct 6, 2023
d131ddb
make fixed-point
makslevental Oct 6, 2023
2d120c9
use loop instead of regex
makslevental Oct 6, 2023
6bf2dc2
incorporate comments
makslevental Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions llvm/lib/Support/StringExtras.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,16 @@ std::string llvm::convertToSnakeFromCamelCase(StringRef input) {

std::string snakeCase;
snakeCase.reserve(input.size());
for (char c : input) {
if (!std::isupper(c)) {
snakeCase.push_back(c);
continue;
}

if (!snakeCase.empty() && snakeCase.back() != '_')
auto check = [&input](size_t j, function_ref<bool(int)> predicate) {
return j < input.size() && predicate(input[j]);
};
for (size_t i = 0; i < input.size(); ++i) {
snakeCase.push_back(tolower(input[i]));
// Handles "runs" of capitals, such as in OPName -> op_name.
if (check(i, isupper) && check(i + 1, isupper) && check(i + 2, islower))
snakeCase.push_back('_');
if ((check(i, islower) || check(i, isdigit)) && check(i + 1, isupper))
snakeCase.push_back('_');
snakeCase.push_back(llvm::toLower(c));
}
return snakeCase;
}
Expand Down
7 changes: 7 additions & 0 deletions llvm/unittests/ADT/StringExtrasTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,13 @@ TEST(StringExtrasTest, ConvertToSnakeFromCamelCase) {

testConvertToSnakeCase("OpName", "op_name");
testConvertToSnakeCase("opName", "op_name");
testConvertToSnakeCase("OPName", "op_name");
testConvertToSnakeCase("Intel_OCL_BI", "intel_ocl_bi");
testConvertToSnakeCase("I32Attr", "i32_attr");
testConvertToSnakeCase("opNAME", "op_name");
testConvertToSnakeCase("opNAMe", "op_na_me");
testConvertToSnakeCase("opnameE", "opname_e");
testConvertToSnakeCase("OPNameOPName", "op_name_op_name");
testConvertToSnakeCase("_OpName", "_op_name");
testConvertToSnakeCase("Op_Name", "op_name");
testConvertToSnakeCase("", "");
Expand Down