Skip to content

Conversation

s-barannikov
Copy link
Contributor

@s-barannikov s-barannikov commented Sep 6, 2023

This change allows to simplify SparcAsmParser a bit by delegating some work (parsing singleton registers) to the code generated by llvm-tblgen.
Other than that, there is no functionality change, because registers are matched using custom code in SparcAsmParser.cpp and always printed in lowercase by SparcInstPrinter.

@s-barannikov s-barannikov requested a review from a team as a code owner September 6, 2023 11:09
Copy link
Contributor

@koachan koachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change allows simplifying SparcAsmParser a bit by delegating some
work (parsing singleton registers) to the code generated by llvm-tblgen.
Other than that, there is no functionality change, because registers are
matched using custom code in SparcAsmParser.cpp and always printed in
lowercase by SparcInstPrinter.
@s-barannikov s-barannikov force-pushed the sparc-lower-case-registers branch from 8c06a0d to 5b005c0 Compare September 7, 2023 07:59
@s-barannikov s-barannikov merged commit 40aa39d into llvm:main Sep 7, 2023
@s-barannikov s-barannikov deleted the sparc-lower-case-registers branch September 7, 2023 08:00
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
This change allows to simplify SparcAsmParser a bit by delegating some
work (parsing singleton registers) to the code generated by llvm-tblgen.
Other than that, there is no functionality change, because registers are
matched using custom code in SparcAsmParser.cpp and always printed in
lowercase by SparcInstPrinter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants