Skip to content

Resolving #171877 #172139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ronxvier wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Resolving #171877 #172139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae2549c
Resolve #171877
Ronxvier Dec 13, 2025
b9a136b
Merge branch 'main' into main
Ronxvier Dec 13, 2025
9f6988a
reformatted
Ronxvier Dec 13, 2025
5d9b081
Update ConstantFolding.cpp
Ronxvier Dec 13, 2025
261aa17
Merge branch 'main' into main
Ronxvier Dec 13, 2025
0a4eead
Merge branch 'main' into main
Ronxvier Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions llvm/lib/Analysis/ConstantFolding.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3241,6 +3241,16 @@ static Constant *ConstantFoldLibCall2(StringRef Name, Type *Ty,
if (TLI->has(Func))
return ConstantFoldBinaryFP(atan2, Op1V, Op2V, Ty);
break;
case LibFunc_fdim:
case LibFunc_fdimf:
case LibFunc_fdiml:
APFloat Difference = Op1V;
Difference.subtract(Op2V, RoundingMode::NearestTiesToEven);

APFloat MaxVal =
maximum(Difference, APFloat::getZero(Ty->getFltSemantics()));
return ConstantFP::get(Ty->getContext(), MaxVal);
break;
}

return nullptr;
Expand Down
14 changes: 2 additions & 12 deletions llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3201,18 +3201,8 @@ Value *LibCallSimplifier::optimizeFdim(CallInst *CI, IRBuilderBase &B) {
if (isa<PoisonValue>(CI->getArgOperand(1)))
return CI->getArgOperand(1);

const APFloat *X, *Y;
// Check if both values are constants
if (!match(CI->getArgOperand(0), m_APFloat(X)) ||
!match(CI->getArgOperand(1), m_APFloat(Y)))
return nullptr;

APFloat Difference = *X;
Difference.subtract(*Y, RoundingMode::NearestTiesToEven);

APFloat MaxVal =
maximum(Difference, APFloat::getZero(CI->getType()->getFltSemantics()));
return ConstantFP::get(CI->getType(), MaxVal);
// Constant folding will be handled by ConstantFoldLibCall2
return nullptr;
}

//===----------------------------------------------------------------------===//
Expand Down