[flang][docs] Add an FAQ about an executable stack #171241
Conversation
yus3710-fj
requested review from
ceseo,
kawashima-fj,
kiranchandramohan,
tarunprabhu and
vzakhari
|
As a non-native English speaker, any feedback on my phrasing is also welcome. |
tarunprabhu
left a comment
tarunprabhu
left a comment
There was a problem hiding this comment.
Thanks for adding this document. I think some small improvements could be made.
Co-authored-by: Tarun Prabhu <[email protected]>
Co-authored-by: Tarun Prabhu <[email protected]>
Co-authored-by: Tarun Prabhu <[email protected]>
tarunprabhu
requested review from
DavidSpickett
and removed request for
tarunprabhu
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
Since I was summoned, I read the document through as well. Bunch of comments but nothing big and overall it's very good.
I've been adding similar material to LLDB's docs and even if people don't find it themselves, it's always convenient to be able to answer questions with a link. It saves a lot of time.
So good idea to add this and I'm sure you'll find more topics to add in future.
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
If all the outstanding comments are addressed, this LGTM. No need to wait for me to review again if @tarunprabhu approves.
Co-authored-by: David Spickett <[email protected]>
tarunprabhu
left a comment
tarunprabhu
left a comment
There was a problem hiding this comment.
Thank you very much for all the changes. Just a few final nits.
Co-authored-by: Tarun Prabhu <[email protected]>
Co-authored-by: Tarun Prabhu <[email protected]>
Co-authored-by: Tarun Prabhu <[email protected]>
Co-authored-by: Tarun Prabhu <[email protected]> Co-authored-by: David Spickett <[email protected]>
5 participants
No description provided.