Skip to content

🍒 [lldb] Fix TestRealDefinition on older DWARF versions #165729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

🍒 [lldb] Fix TestRealDefinition on older DWARF versions #165729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lldb/test/API/lang/objc/real-definition/TestRealDefinition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,11 @@ def test_frame_var_after_stop_at_interface(self):
# Run at stop at main
lldbutil.check_breakpoint(self, bpno=1, expected_hit_count=1)

self.runCmd("settings set target.prefer-dynamic-value no-dynamic-values")

# This should display correctly.
self.expect(
"frame variable foo->_bar->_hidden_ivar",
VARIABLES_DISPLAYED_CORRECTLY,
substrs=["(NSString *)", "foo->_bar->_hidden_ivar = 0x"],
substrs=["foo->_bar->_hidden_ivar = 0x"],
Copy link
Collaborator

@adrian-prantl adrian-prantl Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this would be nicer if it were implemented using the SBAPI instead of expect. Maybe we should upstream lldbutil.check_variable from the Swift branch?

Copy link
Member Author

@Michael137 Michael137 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea can do that as a follow-up

)

def test_frame_var_after_stop_at_implementation(self):
Expand All @@ -54,11 +52,9 @@ def test_frame_var_after_stop_at_implementation(self):
# Run at stop at main
lldbutil.check_breakpoint(self, bpno=1, expected_hit_count=1)

self.runCmd("settings set target.prefer-dynamic-value no-dynamic-values")

# This should display correctly.
self.expect(
"frame variable foo->_bar->_hidden_ivar",
VARIABLES_DISPLAYED_CORRECTLY,
substrs=["(NSString *)", "foo->_bar->_hidden_ivar = 0x"],
substrs=["foo->_bar->_hidden_ivar = 0x"],
)
Loading