Skip to content

Conversation

@DanBlackwell
Copy link
Contributor

Occasionally this test fails in CI. There are two possible races that can occur, one of which is rare. Both are supposed to be handled, but because the test matches "read-only" and the runtime outputs "Read-only" (note the capital letter), the FileCheck fails.

This patch fixes the miscapitalisation of the FileCheck string in the test.

rdar://163398219

Occasionally this test fails in CI. There are two possible races that can occur, one of which is rare. Both are supposed to be handled, but because the test matches "read-only" and the runtime outputs "Read-only" (note the capital letter), the FileCheck fails.

This patch fixes the miscapitalisation of the FileCheck string in the test.
@llvmbot
Copy link
Member

llvmbot commented Oct 29, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Dan Blackwell (DanBlackwell)

Changes

Occasionally this test fails in CI. There are two possible races that can occur, one of which is rare. Both are supposed to be handled, but because the test matches "read-only" and the runtime outputs "Read-only" (note the capital letter), the FileCheck fails.

This patch fixes the miscapitalisation of the FileCheck string in the test.

rdar://163398219


Full diff: https://github.com/llvm/llvm-project/pull/165534.diff

1 Files Affected:

  • (modified) compiler-rt/test/tsan/Darwin/external.cpp (+2-2)
diff --git a/compiler-rt/test/tsan/Darwin/external.cpp b/compiler-rt/test/tsan/Darwin/external.cpp
index 3869c7abb7664..8372a1eb125f3 100644
--- a/compiler-rt/test/tsan/Darwin/external.cpp
+++ b/compiler-rt/test/tsan/Darwin/external.cpp
@@ -68,9 +68,9 @@ int main(int argc, char *argv[]) {
   // TEST2-NOT: WARNING: ThreadSanitizer
   
   // TEST3: WARNING: ThreadSanitizer: race on MyLibrary::MyObject
-  // TEST3: {{Modifying|read-only}} access of MyLibrary::MyObject at
+  // TEST3: {{Modifying|Read-only}} access of MyLibrary::MyObject at
   // TEST3: {{ObjectWrite|ObjectRead}}
-  // TEST3: Previous {{modifying|read-only}} access of MyLibrary::MyObject at
+  // TEST3: Previous {{modifying|Read-only}} access of MyLibrary::MyObject at
   // TEST3: {{ObjectWrite|ObjectRead}}
   // TEST3: Location is MyLibrary::MyObject of size 16 at
   // TEST3: {{ObjectCreate}}

@DanBlackwell DanBlackwell merged commit 2ecb748 into llvm:main Oct 29, 2025
14 checks passed
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 30, 2025
Occasionally this test fails in CI. There are two possible races that
can occur, one of which is rare. Both are supposed to be handled, but
because the test matches "read-only" and the runtime outputs "Read-only"
(note the capital letter), the FileCheck fails.

This patch fixes the miscapitalisation of the FileCheck string in the
test.

rdar://163398219
DEBADRIBASAK pushed a commit to DEBADRIBASAK/llvm-project that referenced this pull request Nov 3, 2025
Occasionally this test fails in CI. There are two possible races that
can occur, one of which is rare. Both are supposed to be handled, but
because the test matches "read-only" and the runtime outputs "Read-only"
(note the capital letter), the FileCheck fails.

This patch fixes the miscapitalisation of the FileCheck string in the
test.

rdar://163398219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants