[NFC][SampleFDO] Use const& to avoid copies #164584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use const& in range-based for loop to avoid unnecessary copies
abhishek-kaushik22
requested review from
mingmingl-llvm and
snehasish
and removed request for
mingmingl-llvm
Member
|
@llvm/pr-subscribers-pgo Author: Abhishek Kaushik (abhishek-kaushik22) ChangesUse const& in range-based for loop to avoid unnecessary copies Full diff: https://github.com/llvm/llvm-project/pull/164584.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ProfileData/SampleProf.h b/llvm/include/llvm/ProfileData/SampleProf.h
index 3dd34aba2d716..05f1b568b0643 100644
--- a/llvm/include/llvm/ProfileData/SampleProf.h
+++ b/llvm/include/llvm/ProfileData/SampleProf.h
@@ -1072,7 +1072,7 @@ class FunctionSamples {
TypeCountMap &TypeCounts = getTypeSamplesAt(Loc);
bool Overflowed = false;
- for (const auto [Type, Count] : Other) {
+ for (const auto &[Type, Count] : Other) {
FunctionId TypeId(Type);
bool RowOverflow = false;
TypeCounts[TypeId] = SaturatingMultiplyAdd(
|
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
Use const& in range-based for loop to avoid unnecessary copies
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
Use const& in range-based for loop to avoid unnecessary copies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use const& in range-based for loop to avoid unnecessary copies