[lit] Fix the missing comma in LIT config #162998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camsyn
changed the title
|
@llvm/pr-subscribers-testing-tools Author: Kunqiu Chen (Camsyn) ChangesThis pull request makes a minor fix to the The change corrects a missing comma in the list of environment variables, ensuring that
Full diff: https://github.com/llvm/llvm-project/pull/162998.diff 1 Files Affected:
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index c134cda90e2ee..cc94389e85f74 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -80,7 +80,8 @@ def __init__(self, lit_config, config):
"HWASAN_SYMBOLIZER_PATH",
"MSAN_SYMBOLIZER_PATH",
"TSAN_SYMBOLIZER_PATH",
- "UBSAN_SYMBOLIZER_PATH" "ASAN_OPTIONS",
+ "UBSAN_SYMBOLIZER_PATH",
+ "ASAN_OPTIONS",
"HWASAN_OPTIONS",
"MSAN_OPTIONS",
"RTSAN_OPTIONS",
|
cmtice
approved these changes
Oct 11, 2025
DharuniRAcharya
pushed a commit
to DharuniRAcharya/llvm-project
that referenced
this pull request
Oct 13, 2025
This pull request makes a minor fix to the `llvm/utils/lit/lit/llvm/config.py` file. The change corrects a missing comma in the list of environment variables, ensuring that `"UBSAN_SYMBOLIZER_PATH"` and `"ASAN_OPTIONS"` are treated as separate entries instead of a single concatenated string. * Fixed a missing comma between `"UBSAN_SYMBOLIZER_PATH"` and `"ASAN_OPTIONS"` in the environment variable list in `llvm/utils/lit/lit/llvm/config.py`, preventing potential configuration issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor fix to the
llvm/utils/lit/lit/llvm/config.pyfile.The change corrects a missing comma in the list of environment variables, ensuring that
"UBSAN_SYMBOLIZER_PATH"and"ASAN_OPTIONS"are treated as separate entries instead of a single concatenated string."UBSAN_SYMBOLIZER_PATH"and"ASAN_OPTIONS"in the environment variable list inllvm/utils/lit/lit/llvm/config.py, preventing potential configuration issues.