Skip to content

[AMDGPU] Fix handling of FP in cs.chain functions #161194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2025
Merged

[AMDGPU] Fix handling of FP in cs.chain functions #161194

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de66e74
[AMDGPU] Fix handling of FP in cs.chain functions
ro-i Mar 24, 2025
97a5437
add gfx942 as test target
ro-i Sep 29, 2025
7ff930c
Update llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-fp-nosave.ll
ro-i Oct 13, 2025
71b32c4
remove unnecessary blocks for variable-sized allocas
ro-i Oct 13, 2025
875b4fb
adapt test comment
ro-i Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2166,7 +2166,9 @@ bool SIFrameLowering::hasFPImpl(const MachineFunction &MF) const {
return MFI.getStackSize() != 0;
}

return frameTriviallyRequiresSP(MFI) || MFI.isFrameAddressTaken() ||
return (frameTriviallyRequiresSP(MFI) &&
!MF.getInfo<SIMachineFunctionInfo>()->isChainFunction()) ||
MFI.isFrameAddressTaken() ||
MF.getSubtarget<GCNSubtarget>().getRegisterInfo()->hasStackRealignment(
MF) ||
mayReserveScratchForCWSR(MF) ||
Expand Down
Loading