Skip to content

Conversation

@cachemeifyoucan
Copy link
Collaborator

Fix AIX build by linking libbsd.a to include implementation for flock.

Created using spr 1.3.6
@amy-kwan
Copy link
Contributor

Sorry for the delayed update - this patch works (thanks!) but it might not be needed. The AIX bot is actually fine with the previous fix for the unused variable (https://lab.llvm.org/buildbot/#/builders/64/builds/5841), so I suspect I might be running into local environment related issues but will report back. I can close this PR if it's not necessary. Thanks again for helping with this and I apologize for the inconvenience!

@amy-kwan
Copy link
Contributor

I believe this patch is not needed, so I will close this PR for now. Thank you again for your assistance in this issue! Greatly appreciate it!

@amy-kwan
Copy link
Contributor

Hi @cachemeifyoucan, hope you don't mind me reopening this PR as this does fix the AIX build this time around. Would you be able to rebase this PR?

@amy-kwan amy-kwan reopened this Nov 11, 2025
Created using spr 1.3.7
@cachemeifyoucan
Copy link
Collaborator Author

@amy-kwan Sure. Rebased. Are you able to reproduce the error I mentioned in the other PR and able to check this PR fixes the problem?

Copy link
Member

@daltenty daltenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@amy-kwan amy-kwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cachemeifyoucan!
Confirmed that this patch resolves the AIX build, so LGTM.

@cachemeifyoucan cachemeifyoucan enabled auto-merge (squash) November 11, 2025 19:45
@cachemeifyoucan cachemeifyoucan merged commit cc5057c into main Nov 11, 2025
8 of 9 checks passed
@cachemeifyoucan cachemeifyoucan deleted the users/cachemeifyoucan/spr/cas-fix-aix-build branch November 11, 2025 19:49
@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 12, 2025

LLVM Buildbot has detected a new failure on builder llvm-clang-x86_64-darwin running on doug-worker-3 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/15468

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Driver/visibility-global-new-delete.cl' FAILED ********************
Exit Code: 127

Command Output (stdout):
--
# RUN: at line 4
/Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/clang -### --target=x86_64-unknown-unknown -c -emit-llvm /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl 2>&1 |    /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck -check-prefix=DEFAULTS /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl
# executed command: /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/clang '-###' --target=x86_64-unknown-unknown -c -emit-llvm /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl
# note: command had no output on stdout or stderr
# executed command: /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck -check-prefix=DEFAULTS /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl
# note: command had no output on stdout or stderr
# RUN: at line 12
/Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/clang -### --target=x86_64-sie-ps5 -c -emit-llvm /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl 2>&1 |    /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck -check-prefix=PS5 /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl
# executed command: /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/clang '-###' --target=x86_64-sie-ps5 -c -emit-llvm /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl
# note: command had no output on stdout or stderr
# executed command: /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck -check-prefix=PS5 /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl
# note: command had no output on stdout or stderr
# RUN: at line 17
/Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/clang -### --target=x86_64-unknown-unknown -c -emit-llvm    -fvisibility-global-new-delete-hidden /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl 2>&1 | /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck -check-prefixes=VGNDH,DEPRECATED /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl --implicit-check-not=-fvisibility-global-new-delete= --implicit-check-not=-fvisibility-global-new-delete-hidden
# executed command: /Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck -check-prefixes=VGNDH,DEPRECATED /Volumes/RAMDisk/buildbot-root/x86_64-darwin/llvm-project/clang/test/Driver/visibility-global-new-delete.cl --implicit-check-not=-fvisibility-global-new-delete= --implicit-check-not=-fvisibility-global-new-delete-hidden
# .---command stderr------------
# | Could not create process (/Volumes/RAMDisk/buildbot-root/x86_64-darwin/build/bin/FileCheck) due to [Errno 24] Too many open files
# `-----------------------------
# error: command failed with exit status: 127

--

********************


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants