Skip to content

[lldb] Use numeric_limits for all overflow checks in ObjectFileWasm #153332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JDevlieghere merged 1 commit into from
Aug 13, 2025
Merged

[lldb] Use numeric_limits for all overflow checks in ObjectFileWasm #153332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ GetWasmString(llvm::DataExtractor &data, llvm::DataExtractor::Cursor &c) {
return std::nullopt;
}

if (len >= (uint64_t(1) << 32)) {
if (len > std::numeric_limits<uint32_t>::max()) {
return std::nullopt;
}

Expand Down Expand Up @@ -175,7 +175,7 @@ bool ObjectFileWasm::DecodeNextSection(lldb::offset_t *offset_ptr) {
if (!c)
return !llvm::errorToBool(c.takeError());

if (payload_len >= (uint64_t(1) << 32))
if (payload_len > std::numeric_limits<uint32_t>::max())
return false;

if (section_id == llvm::wasm::WASM_SEC_CUSTOM) {
Expand Down Expand Up @@ -256,15 +256,15 @@ ParseFunctions(SectionSP code_section_sp) {
lldb::offset_t offset = 0;

const uint64_t function_count = code_section_data.GetULEB128(&offset);
if (function_count >= std::numeric_limits<uint32_t>::max())
if (function_count > std::numeric_limits<uint32_t>::max())
return llvm::createStringError("function count overflows uint32_t");

std::vector<AddressRange> functions;
functions.reserve(function_count);

for (uint32_t i = 0; i < function_count; ++i) {
const uint64_t function_size = code_section_data.GetULEB128(&offset);
if (function_size >= std::numeric_limits<uint32_t>::max())
if (function_size > std::numeric_limits<uint32_t>::max())
return llvm::createStringError("function size overflows uint32_t");
// llvm-objdump considers the ULEB with the function size to be part of the
// function. We can't do that here because that would break symbolic
Expand Down Expand Up @@ -293,13 +293,13 @@ ParseNames(SectionSP name_section_sp,
while (c && c.tell() < data.size()) {
const uint8_t type = data.getU8(c);
const uint64_t size = data.getULEB128(c);
if (size >= std::numeric_limits<uint32_t>::max())
if (size > std::numeric_limits<uint32_t>::max())
return llvm::createStringError("size overflows uint32_t");

switch (type) {
case llvm::wasm::WASM_NAMES_FUNCTION: {
const uint64_t count = data.getULEB128(c);
if (count >= std::numeric_limits<uint32_t>::max())
if (count > std::numeric_limits<uint32_t>::max())
return llvm::createStringError("function count overflows uint32_t");

for (uint64_t i = 0; c && i < count; ++i) {
Expand Down
Loading