Skip to content

Conversation

Sirraide
Copy link
Member

This is a follow-up to #149079. Seems like we forgot about the fact that the symbols also need to be in libclang.map...

I’ve taken another look at #119269, so I do hope that this is the last thing we need to undo...

This will also have to be cherry-picked to the release branch.

@Sirraide Sirraide requested review from nico and AaronBallman July 16, 2025 21:42
@Sirraide Sirraide added the clang:as-a-library libclang and C++ API label Jul 16, 2025
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jul 16, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 16, 2025

@llvm/pr-subscribers-clang

Author: None (Sirraide)

Changes

This is a follow-up to #149079. Seems like we forgot about the fact that the symbols also need to be in libclang.map...

I’ve taken another look at #119269, so I do hope that this is the last thing we need to undo...

This will also have to be cherry-picked to the release branch.


Full diff: https://github.com/llvm/llvm-project/pull/149190.diff

1 Files Affected:

  • (modified) clang/tools/libclang/libclang.map (+5)
diff --git a/clang/tools/libclang/libclang.map b/clang/tools/libclang/libclang.map
index 49c472e3833fd..3d9d2e268a611 100644
--- a/clang/tools/libclang/libclang.map
+++ b/clang/tools/libclang/libclang.map
@@ -327,6 +327,8 @@ LLVM_13 {
     clang_getRange;
     clang_getRangeEnd;
     clang_getRangeStart;
+    clang_getRemappings;
+    clang_getRemappingsFromFileList;
     clang_getResultType;
     clang_getSkippedRanges;
     clang_getSpecializedCursorTemplate;
@@ -387,6 +389,9 @@ LLVM_13 {
     clang_parseTranslationUnit;
     clang_parseTranslationUnit2;
     clang_parseTranslationUnit2FullArgv;
+    clang_remap_dispose;
+    clang_remap_getFilenames;
+    clang_remap_getNumFiles;
     clang_reparseTranslationUnit;
     clang_saveTranslationUnit;
     clang_sortCodeCompletionResults;

Copy link
Contributor

@nico nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nico nico merged commit 7e0fde0 into llvm:main Jul 16, 2025
14 checks passed
@AaronBallman AaronBallman added this to the LLVM 21.x Release milestone Jul 17, 2025
@AaronBallman
Copy link
Collaborator

/cherry-pick 7e0fde0

@llvmbot
Copy link
Member

llvmbot commented Jul 17, 2025

/pull-request #149287

@llvmbot llvmbot moved this from Needs Triage to Done in LLVM Release Status Jul 17, 2025
tru pushed a commit to llvmbot/llvm-project that referenced this pull request Jul 17, 2025
This is a follow-up to llvm#149079. Seems like we forgot about the fact that
the symbols also need to be in `libclang.map`.

(cherry picked from commit 7e0fde0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:as-a-library libclang and C++ API clang Clang issues not falling into any other category
Projects
Development

Successfully merging this pull request may close these issues.

4 participants