Skip to content

[VPlan] Remove redundant debug location setting in VPInterleaveRecipe::execute. nfc #146670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

[VPlan] Remove redundant debug location setting in VPInterleaveRecipe::execute. nfc #146670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3425,10 +3425,6 @@ void VPInterleaveRecipe::execute(VPTransformState &State) {

VPValue *Addr = getAddr();
Value *ResAddr = State.get(Addr, VPLane(0));
if (auto *I = dyn_cast<Instruction>(ResAddr))
State.setDebugLocFrom(I->getDebugLoc());
Comment on lines -3428 to -3429
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making a note here, is this strictly NFC? VPBasicBlock::executeRecipes takes the debug location always from the recipe but this seems to copy it from the address. I don't think this is important

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch didn't actually touch any debug locs.
I just realized it was probably #144864 that modified the address debug loc. Perhaps we could revert to using the debug location from Addr, if necessary.


State.setDebugLocFrom(getDebugLoc());
Value *PoisonVec = PoisonValue::get(VecTy);

auto CreateGroupMask = [&BlockInMask, &State,
Expand Down
Loading