Skip to content

[InstCombine] Rewrite multi-use GEPs when simplifying comparison #146100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikic merged 2 commits into from
Jul 1, 2025
Merged

[InstCombine] Rewrite multi-use GEPs when simplifying comparison #146100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c503c5e
test
nikic Jun 27, 2025
a9122c1
rewrite multi-use geps during fold
nikic Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ Instruction *InstCombinerImpl::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Value *PtrBase = GEPLHS->getOperand(0);
if (PtrBase == RHS && CanFold(GEPLHS->getNoWrapFlags())) {
// ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
Value *Offset = EmitGEPOffset(GEPLHS);
Value *Offset = EmitGEPOffset(GEPLHS, /*RewriteGEP=*/true);
return NewICmp(GEPLHS->getNoWrapFlags(), Offset,
Constant::getNullValue(Offset->getType()));
}
Expand Down
28 changes: 28 additions & 0 deletions llvm/test/Transforms/InstCombine/icmp-gep.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,34 @@ define i1 @eq_base_inbounds_commute_use(i64 %y) {
ret i1 %r
}

define i1 @ne_base_inbounds_use_scaled(ptr %x, i64 %y) {
; CHECK-LABEL: @ne_base_inbounds_use_scaled(
; CHECK-NEXT: [[G_IDX:%.*]] = shl nsw i64 [[Y:%.*]], 3
; CHECK-NEXT: [[G:%.*]] = getelementptr inbounds i8, ptr [[X:%.*]], i64 [[G_IDX]]
; CHECK-NEXT: call void @use(ptr [[G]])
; CHECK-NEXT: [[R:%.*]] = icmp ne i64 [[Y]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%g = getelementptr inbounds i64, ptr %x, i64 %y
call void @use(ptr %g)
%r = icmp ne ptr %g, %x
ret i1 %r
}

define i1 @ne_base_use_scaled(ptr %x, i64 %y) {
; CHECK-LABEL: @ne_base_use_scaled(
; CHECK-NEXT: [[G_IDX_MASK:%.*]] = shl i64 [[Y:%.*]], 3
; CHECK-NEXT: [[G:%.*]] = getelementptr i8, ptr [[X:%.*]], i64 [[G_IDX_MASK]]
; CHECK-NEXT: call void @use(ptr [[G]])
; CHECK-NEXT: [[R:%.*]] = icmp ne i64 [[G_IDX_MASK]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%g = getelementptr i64, ptr %x, i64 %y
call void @use(ptr %g)
%r = icmp ne ptr %g, %x
ret i1 %r
}

define i1 @eq_bitcast_base(ptr %p, i64 %x) {
; CHECK-LABEL: @eq_bitcast_base(
; CHECK-NEXT: [[GEP_IDX_MASK:%.*]] = and i64 [[X:%.*]], 9223372036854775807
Expand Down
3 changes: 2 additions & 1 deletion llvm/test/Transforms/PhaseOrdering/loop-access-checks.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ define void @test_fill_with_foreach([2 x i64] %elems.coerce) {
; CHECK-NEXT: [[ELEMS_COERCE_FCA_0_EXTRACT:%.*]] = extractvalue [2 x i64] [[ELEMS_COERCE]], 0
; CHECK-NEXT: [[TMP0:%.*]] = inttoptr i64 [[ELEMS_COERCE_FCA_0_EXTRACT]] to ptr
; CHECK-NEXT: [[ELEMS_COERCE_FCA_1_EXTRACT:%.*]] = extractvalue [2 x i64] [[ELEMS_COERCE]], 1
; CHECK-NEXT: [[ADD_PTR_I:%.*]] = getelementptr inbounds i32, ptr [[TMP0]], i64 [[ELEMS_COERCE_FCA_1_EXTRACT]]
; CHECK-NEXT: [[ADD_PTR_I_IDX:%.*]] = shl nsw i64 [[ELEMS_COERCE_FCA_1_EXTRACT]], 2
; CHECK-NEXT: [[ADD_PTR_I:%.*]] = getelementptr inbounds i8, ptr [[TMP0]], i64 [[ADD_PTR_I_IDX]]
; CHECK-NEXT: [[CMP_NOT_I_I_I_I:%.*]] = icmp slt i64 [[ELEMS_COERCE_FCA_1_EXTRACT]], 0
; CHECK-NEXT: br i1 [[CMP_NOT_I_I_I_I]], label [[ERROR:%.*]], label [[FOR_COND_PREHEADER_SPLIT:%.*]]
; CHECK: for.cond.preheader.split:
Expand Down