[OpenMP] Improve performance of ticket lock (x86) #143557
Merged
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket lock has a yield operation which degrades performance on larger server machines due to an unconditional pause operation.
hansangbae
reviewed
Jun 10, 2025
|
ping. @hansangbae please review and complete this. Thanks! |
jprotze
approved these changes
Jul 20, 2025
There was a problem hiding this comment.
I think, having the KMP_YIELD macro in the commit message would make it easier to understand the actual problem when just looking at the diff of the patch. After checking the define the issue is clear and the patch LGTM.
#define KMP_YIELD(cond) \
{ \
KMP_CPU_PAUSE(); \
if ((cond) && (KMP_TRY_YIELD)) \
__kmp_yield(); \
}
|
Merged the change with the suggested commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket lock has a yield operation (shown below) which degrades performance on larger server machines due to an unconditional pause operation.