Skip to content

[MLIR] Document the need for updating the cached symbol tables during bufferization #141594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

[MLIR] Document the need for updating the cached symbol tables during bufferization #141594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,11 @@ def BufferizableOpInterface : OpInterface<"BufferizableOpInterface"> {
expected to survive bufferization, `success` should be returned
(together with `allow-unknown-ops` enabled).

If the bufferized operation has symbol semantics (i.e., it defines a
symbol or a symbol table), the implementation is expected to update
the cached symbol tables -- within the bufferization state -- to keep
them in a consistent state.

Note: If this op supports unstructured control flow in its regions,
then this function should also bufferize all block signatures that
belong to this op. Branch ops (that branch to a block) are typically
Expand Down