Add a GUIDLIST table to bitcode #139497
Draft
Add a GUIDLIST table to bitcode #139497
+36
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
orodley
force-pushed
the
users/orodley/guid-2
branch
from
9559e0f to
61108c7
Compare
orodley
force-pushed
the
users/orodley/05-12-add_a_guidlist_table_to_bitcode
branch
from
bfb6cb2 to
553845e
Compare
orodley
force-pushed
the
users/orodley/guid-2
branch
from
61108c7 to
e40c56f
Compare
orodley
force-pushed
the
users/orodley/05-12-add_a_guidlist_table_to_bitcode
branch
from
553845e to
bf53f87
Compare
orodley
force-pushed
the
users/orodley/05-12-add_a_guidlist_table_to_bitcode
branch
from
bf53f87 to
7f599c7
Compare
orodley
force-pushed
the
users/orodley/guid-2
branch
from
e40c56f to
3da1ceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discourse.llvm.org/t/rfc-keep-globalvalue-guids-stable/84801
for context.
GUIDs are stored in metadata, so generally don't need to be explicitly
copied into bitcode. But function importing loads functions lazily, importing
metadata only along with the function body. We need the GUID before
we've imported the body. This side table will fulfil this requirement.
This PR only reads/writes the table, it doesn't yet use it for building the
module summary index.