[KeyInstr] Complex assignment atoms #134638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2025
llvmbot
added
clang
This was referenced Apr 7, 2025
This was referenced Apr 7, 2025
OCHyams
removed request for
hanhanW,
bcardosolopes,
maksfb,
rafaelauler,
nicolasvasilache,
lanza,
yota9,
dcaballe,
cyndyishida,
PeimingLiu,
aartbik,
ayermolo and
yinying-lisa-li
|
Sorry to all that were added... grappling with messed-up graphite internal state, GitHub enjoys adding reviewers for me when I change base. |
This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context for this PR, here: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668 The feature is only functional in LLVM if LLVM is built with CMake flag LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed. The Clang-side work is demoed here: #130943
OCHyams
force-pushed
the
users/OCHyams/ki-clang-complex
branch
from
ebd8acd to
70856b8
Compare
|
Sorry I misunderstood what you were saying. Fixed, this should now have symmetry with prior patches. Expanded the test coverage. There's 4 binop assign calls that are instrumented individually which reflects the previous patch's macro usage. The expanded test coverage identified a redundant atom group nesting, which is now also fixed (and could only be fixed with the symmetrical approach, hurray). Thanks for the keen eyed review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.
The Key Instructions project is introduced, including a "quick summary" section
at the top which adds context for this PR, here:
https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668
The feature is only functional in LLVM if LLVM is built with CMake flag
LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed.
The Clang-side work is demoed here:
#130943