Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

This patch refactors the generate_test_report script, namely turning it
into a proper library, and pulling the script/unittests out into
separate files, as is standard with most python scripts. The main
purpose of this is to enable reusing the library for the new Github
premerge.

Created using spr 1.3.4
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was thinking why don't you have the same entry point for GitHub and Buildkite as for now, the only difference would be that the environment variables wouldn't be set.

But that is not the only difference, in buildkite there is an agent to send the report to. There is not in Github.

So I like splitting this so you can have a GitHub entry point, as you do in the follow up PR.

(and btw, don't feel the need to keep any of this code if it would be easier to junk it and use something custom or a built-in GitHub feature if you find one)

Created using spr 1.3.4
Created using spr 1.3.4
@boomanaiden154 boomanaiden154 merged commit 2fb53f5 into main Mar 27, 2025
6 of 10 checks passed
@boomanaiden154 boomanaiden154 deleted the users/boomanaiden154/ci-refactor-generate_test_report-script branch March 27, 2025 19:59
@boomanaiden154
Copy link
Contributor Author

(and btw, don't feel the need to keep any of this code if it would be easier to junk it and use something custom or a built-in GitHub feature if you find one)

For now this seems like the path of least resistance. We could do things a bit nicer in Github, but there are tradeoffs, mainly with parallelism if we want to split the job into multiple steps that each invoke their own test targets.

llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Mar 27, 2025
This patch refactors the generate_test_report script, namely turning it
into a proper library, and pulling the script/unittests out into
separate files, as is standard with most python scripts. The main
purpose of this is to enable reusing the library for the new Github
premerge.

Reviewers: tstellar, DavidSpickett, Keenuts, lnihlen

Reviewed By: DavidSpickett

Pull Request: llvm/llvm-project#133196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants