Skip to content

llvm-reduce: Fix operand reduction asserting on target ext types #132732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

llvm-reduce: Fix operand reduction asserting on target ext types #132732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e2d9ce
llvm-reduce: Fix operand reduction asserting on target ext types
arsenm Mar 24, 2025
4cbb8fe
Avoid replacing cases that are already set to the constant
arsenm Mar 24, 2025
633b42c
Do not form poison in zero reduction
arsenm Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions llvm/test/tools/llvm-reduce/reduce-operands-target-ext-ty.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-zero --test FileCheck --test-arg %s --test-arg --input-file %s -o %t
; RUN: FileCheck --check-prefixes=CHECK,ZERO %s < %t

; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-one --test FileCheck --test-arg %s --test-arg --input-file %s -o %t
; RUN: FileCheck --check-prefixes=CHECK,ONE %s < %t

declare void @uses_ext_ty(target("sometarget.sometype"))

; TODO: Should support reduce to poison
; CHECK-LABEL: @foo(
; ZERO: call void @uses_ext_ty(target("sometarget.sometype") %arg)
; ONE: call void @uses_ext_ty(target("sometarget.sometype") %arg)
define void @foo(target("sometarget.sometype") %arg) {
call void @uses_ext_ty(target("sometarget.sometype") %arg)
ret void
}

declare void @uses_zeroinit_ext_ty(target("sometarget.sometype"))

; CHECK-LABEL: @bar(
; ZERO: call void @uses_zeroinit_ext_ty(target("spirv.sometype") zeroinitializer)
; ONE: call void @uses_zeroinit_ext_ty(target("spirv.sometype") %arg)
define void @bar(target("spirv.sometype") %arg) {
call void @uses_zeroinit_ext_ty(target("spirv.sometype") %arg)
ret void
}
11 changes: 11 additions & 0 deletions llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,17 @@ void llvm::reduceOperandsZeroDeltaPass(TestRunner &Test) {
if (auto *IntTy = dyn_cast<IntegerType>(Op->getType()))
if (switchCaseExists(Op, ConstantInt::get(IntTy, 0)))
return nullptr;

if (auto *TET = dyn_cast<TargetExtType>(Op->getType())) {
if (isa<ConstantTargetNone, PoisonValue>(Op))
return nullptr;
if (TET->hasProperty(TargetExtType::HasZeroInit))
return ConstantTargetNone::get(TET);

// TODO: Poison reduction for this case
return nullptr;
}

// Don't replace existing zeroes.
return isZero(Op) ? nullptr : Constant::getNullValue(Op->getType());
};
Expand Down
Loading