Skip to content

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Mar 19, 2025

Fix regression: #131431 (comment)

@c8ef c8ef changed the title Draft [libc] Fix size_t and unsigned long mismatch on riscv32 in test. Mar 19, 2025
@c8ef c8ef marked this pull request as ready for review March 19, 2025 14:02
@llvmbot llvmbot added the libc label Mar 19, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 19, 2025

@llvm/pr-subscribers-libc

Author: Connector Switch (c8ef)

Changes

Fix regression: #131431 (comment)


Full diff: https://github.com/llvm/llvm-project/pull/132028.diff

1 Files Affected:

  • (modified) libc/test/src/search/lsearch_test.cpp (+1-1)
diff --git a/libc/test/src/search/lsearch_test.cpp b/libc/test/src/search/lsearch_test.cpp
index f15ed217181ef..9e58b87772c3b 100644
--- a/libc/test/src/search/lsearch_test.cpp
+++ b/libc/test/src/search/lsearch_test.cpp
@@ -44,7 +44,7 @@ TEST(LlvmLibcLsearchTest, SearchNonExistent) {
   void *ret = LIBC_NAMESPACE::lsearch(&key, list, &len, sizeof(int), compar);
   ASSERT_TRUE(ret == &list[3]);
   ASSERT_EQ(key, list[3]);
-  ASSERT_EQ(len, 4UL);
+  ASSERT_EQ(len, size_t{4});
 }
 
 TEST(LlvmLibcLsearchTest, SearchExceptional) {

@c8ef c8ef merged commit 2d09028 into main Mar 19, 2025
18 of 19 checks passed
@c8ef c8ef deleted the users/c8ef/fix-riscv32-test branch March 19, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants